mclow.lists closed this revision.
mclow.lists added a comment.
Landed as revision 247036
http://reviews.llvm.org/D11380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM modulo handling C++03. Currently compiles w/
clang in C++03. Please either ensure your portions of the searchers also
compile in C++03 and change the tests or #ifdef them out before comm
mclow.lists marked 3 inline comments as done.
mclow.lists added a comment.
http://reviews.llvm.org/D11380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mclow.lists updated this revision to Diff 33770.
mclow.lists added a comment.
Updated based on Eric's comments.
http://reviews.llvm.org/D11380
Files:
include/experimental/functional
test/std/experimental/algorithms/alg.search/search.pass.cpp
test/std/experimental/func/func.searchers/func
mclow.lists added a comment.
Two comments answered. One still remaining.
Comment at: include/experimental/functional:256
@@ +255,3 @@
+
+public: // TODO private:
+_RandomAccessIterator1 __first_;
EricWF wrote:
> Is this for testing?
Well, for debuggi
EricWF added a comment.
@mclow.lists I'm holding off on more review until the current comments are
addressed.
http://reviews.llvm.org/D11380
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
EricWF added a comment.
Added more review comments for the boyer_moore searcher.
Comment at: include/experimental/functional:256
@@ +255,3 @@
+
+public: // TODO private:
+_RandomAccessIterator1 __first_;
Is this for testing?
Comment
