[PATCH] D113518: [clang][Sema] Create delegating constructors even in templates

fwolff added a comment. @aaron.ballman Ping? I think I've responded to all comments so far; let me know if you still have concerns. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113518/new/ https://reviews.llvm.org/D113518 ___ cfe-commits ma

[PATCH] D113518: [clang][Sema] Create delegating constructors even in templates

fwolff marked 2 inline comments as done. fwolff added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4524-4525 if (!Dependent) { -if (Context.hasSameUnqualifiedType(QualType(ClassDecl->getTypeForDecl(),0), - BaseType)) +

[PATCH] D113518: [clang][Sema] Create delegating constructors even in templates

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:4524-4525 if (!Dependent) { -if (Context.hasSameUnqualifiedType(QualType(ClassDecl->getTypeForDecl(),0), - BaseType)) +if (Delegating) return Bu

[PATCH] D113518: [clang][Sema] Create delegating constructors even in templates

whisperity added a comment. In D113518#3155040 , @carlosgalvezp wrote: > Thanks for the finding and sorry for delaying the review, I didn't know that > :( Do you know if there's an option for signaling "LGTM but I want someone > else to review?". Other

[PATCH] D113518: [clang][Sema] Create delegating constructors even in templates

carlosgalvezp added a comment. Thanks for the finding and sorry for delaying the review, I didn't know that :( Do you know if there's an option for signaling "LGTM but I want someone else to review?". Otherwise I can just leave a comment and don't accept the revision. CHANGES SINCE LAST ACTION

[PATCH] D113518: [clang][Sema] Create delegating constructors even in templates

whisperity edited reviewers, added: Quuxplusone; removed: carlosgalvezp, whisperity. whisperity added subscribers: carlosgalvezp, whisperity. whisperity added a comment. This revision now requires review to proceed. (@carlosgalvezp Removing you from reviewers so the patch shows up as not yet rev