This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
yaxunl marked an inline comment as done.
Closed by commit rGb472bd855ed8: [NFC] Let Microsoft mangler accept GlobalDecl
(authored by yaxunl).
Herald added a project: cl
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: clang/lib/AST/MicrosoftMangle.cpp:47
+ if (auto *CD = dyn_cast(DC))
+GD = GlobalDecl(CD, Ctor_Complete);
+ else if (auto *DD = dyn_cast(DC))
yaxunl marked 2 inline comments as done.
yaxunl added inline comments.
Comment at: clang/lib/AST/MicrosoftMangle.cpp:47
+ if (auto *CD = dyn_cast(DC))
+GD = GlobalDecl(CD, Ctor_Complete);
+ else if (auto *DD = dyn_cast(DC))
rnk wrote:
> I would prefer if yo
rnk added inline comments.
Comment at: clang/lib/AST/MicrosoftMangle.cpp:47
+ if (auto *CD = dyn_cast(DC))
+GD = GlobalDecl(CD, Ctor_Complete);
+ else if (auto *DD = dyn_cast(DC))
I would prefer if you passed Ctor_Base and Dtor_Base here. I believe MSVC
mo
tra added a reviewer: rnk.
tra added a subscriber: rnk.
tra added a comment.
+ @rnk as it's a windows-specific change.
LGTM in general.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113490/new/
https://reviews.llvm.org/D113490
___
cfe-commit
yaxunl created this revision.
yaxunl added reviewers: rjmccall, tra.
yaxunl requested review of this revision.
This is a follow up of https://reviews.llvm.org/D75700
where support of GlobalDecl with Microsoft mangler
is incomplete.
https://reviews.llvm.org/D113490
Files:
clang/lib/AST/Microso
