[PATCH] D113489: [AArch64][SVE] Instcombine SVE LD1/ST1 to stock LLVM IR

2021-11-16 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau added a comment. This caused buildbot failures which failed on the bfloat tests. Pushed commit 83727f27719d3f319f746b473ce09be7e1d99b32 to fix the issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D113489: [AArch64][SVE] Instcombine SVE LD1/ST1 to stock LLVM IR

2021-11-15 Thread Paul Walker via Phabricator via cfe-commits
paulwalker-arm accepted this revision. paulwalker-arm added a comment. This revision is now accepted and ready to land. There's an issue with the a `Value*` being named `VecPtrTy` but otherwise this looks good to me. I'll leave it up to you to decide whether it's worth breaking out the usage of

[PATCH] D113489: [AArch64][SVE] Instcombine SVE LD1/ST1 to stock LLVM IR

2021-11-15 Thread Peter Waller via Phabricator via cfe-commits
peterwaller-arm added a comment. My current thinking is that the route forward is to update the tests without update test checks, which affects only the st1{b,h,w} files, and possibly to remove the false header implying these files were autogenerated. Repository: rG LLVM Github Monorepo CHA

[PATCH] D113489: [AArch64][SVE] Instcombine SVE LD1/ST1 to stock LLVM IR

2021-11-15 Thread Peter Waller via Phabricator via cfe-commits
peterwaller-arm added a comment. It looks like some auto-generation lines were added in 91eda9c30f33da6ec6da70b59a5f5da6c6397039 , but the tests using CHECK-DAG were not actually auto-generated. It seems we could either clean

[PATCH] D113489: [AArch64][SVE] Instcombine SVE LD1/ST1 to stock LLVM IR

2021-11-15 Thread Peter Waller via Phabricator via cfe-commits
peterwaller-arm added inline comments. Comment at: clang/test/CodeGen/aarch64-sve-intrinsics/acle_sve_st1w.c:235 +// CHECK-NEXT:ret void +// void test_svst1w_scatter_u64base_index_u64(svbool_t pg, svuint64_t bases, int64_t index, svuint64_t data) Unfortunat

[PATCH] D113489: [AArch64][SVE] Instcombine SVE LD1/ST1 to stock LLVM IR

2021-11-12 Thread Matt Devereau via Phabricator via cfe-commits
MattDevereau marked 9 inline comments as done. MattDevereau added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:732 + Type *VecTyPtr = II.getType()->getPointerTo(); + IRBuilder<> Builder(II.getContext()); + Builder.SetInsertPoint(&II); ---