[PATCH] D113431: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen

This revision was automatically updated to reflect the committed changes. Closed by commit rGce91540beeff: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen (authored by ibookstein). Changed prior to commit: https://reviews.llvm.org/D113431?vs=385923&id=385966#toc Repository: rG

[PATCH] D113431: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen

ibookstein added a comment. Right; well, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113431/new/ https://reviews.llvm.org/D113431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[PATCH] D113431: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. In D113431#3119716 , @ibookstein wrote: > If you meant fusing the clang-format commit with this one, doing it in the > same commit results in

[PATCH] D113431: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen

ibookstein added a comment. If you meant fusing the clang-format commit with this one, doing it in the same commit results in git no longer detecting the connection between them (similarity too low), so it loses the history. When searching I found a recommendation

[PATCH] D113431: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen

erichkeane added a comment. I've got no problem with this, but it could just as easily have happened in the other review. Is there a reason not to? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113431/new/ https://reviews.llvm.org/D113431 __

[PATCH] D113431: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen

ibookstein updated this revision to Diff 385923. ibookstein added a comment. add parent clang-format commit to pass CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113431/new/ https://reviews.llvm.org/D113431 Files: clang/test/CodeGen/attr-ifun

[PATCH] D113431: [clang][test][NFC] Move attr-ifunc.c test from Sema to CodeGen

ibookstein created this revision. ibookstein published this revision for review. Herald added a project: clang. Herald added a subscriber: cfe-commits. Signed-off-by: Itay Bookstein Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113431 Files: clang/test/CodeGen/attr-ifunc.c