[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

2021-11-09 Thread Carlos Galvez via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7ecec3f0f521: [CUDA] Bump supported CUDA version to 11.5 (authored by carlosgalvezp). Changed prior to commit: https://reviews.llvm.org/D113249?vs=385286&id=385717#toc Repository: rG LLVM Github Mono

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

2021-11-08 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. Awesome, thanks a lot for the reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113249/new/ https://reviews.llvm.org/D113249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

2021-11-08 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. In D113249#3117541 , @carlosgalvezp wrote: > @Hahnfeld Are you satisfied with the replies to your questions? If so I can > go ahead and merge. Yes yes, I'm happy if @tra is happy :) CHANGES SINCE LAST ACTION https://review

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

2021-11-08 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. @Hahnfeld Are you satisfied with the replies to your questions? If so I can go ahead and merge. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113249/new/ https://reviews.llvm.org/D113249 ___ cfe-commits mailing

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

2021-11-08 Thread Artem Belevich via Phabricator via cfe-commits
tra accepted this revision. tra added a comment. This revision is now accepted and ready to land. In D113249#3113666 , @carlosgalvezp wrote: >> - The driver needs to enable ptx75 when it constructs cc1 command line in >> clang/lib/Driver/ToolChains/Cuda

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

2021-11-06 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp updated this revision to Diff 385286. carlosgalvezp added a comment. Update release notes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113249/new/ https://reviews.llvm.org/D113249 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/include/clang/Basic/Cuda.h c

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

2021-11-06 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. > - The driver needs to enable ptx75 when it constructs cc1 command line in > clang/lib/Driver/ToolChains/Cuda.cpp @tra Haven't I already done it in line 712? Or where should I enable it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113249/new/ https://

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

2021-11-06 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp updated this revision to Diff 385284. carlosgalvezp added a comment. Updated BuilintsNVPTX.def CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113249/new/ https://reviews.llvm.org/D113249 Files: clang/include/clang/Basic/BuiltinsNVPTX.def clang/include/clang/Basic/Cuda.

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

2021-11-05 Thread Artem Belevich via Phabricator via cfe-commits
tra added a comment. In D113249#3112279 , @Hahnfeld wrote: > Experimental support for `__int128` is new in CUDA 11.5, not sure if Clang > enables this for CUDA. I think we've added support for i128 a while back: https://godbolt.org/z/18bEbhMYb > The r

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

2021-11-05 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. Experimental support for `__int128` is new in CUDA 11.5, not sure if Clang enables this for CUDA. The release notes also specify > `builtin_assume` can now be used to specify address space to allow for > efficient loads and stores. The docs are very scarce on this, I

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

2021-11-05 Thread Artem Belevich via Phabricator via cfe-commits
tra requested changes to this revision. tra added a comment. This revision now requires changes to proceed. I think we're missing few more changes here: - The driver needs to enable ptx75 when it constructs cc1 command line in clang/lib/Driver/ToolChains/Cuda.cpp - We also need to handle PTX75 i

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

2021-11-05 Thread Carlos Galvez via Phabricator via cfe-commits
carlosgalvezp added a comment. In D113249#3110954 , @Hahnfeld wrote: > I'm not sure if it's actually correct to advertise full support for CUDA > 11.5, but I didn't look into exact changes since 11.4 Good point. I was confused about the fact that 11.4 i

[PATCH] D113249: [CUDA] Bump CUDA version to 11.5

2021-11-05 Thread Jonas Hahnfeld via Phabricator via cfe-commits
Hahnfeld added a comment. I'm not sure if it's actually correct to advertise full support for CUDA 11.5, but I didn't look into exact changes since 11.4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113249/new/ https://reviews.llvm.org/D113249 __