[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1510595dce9c: [Sema] Mark explicit specialization declaration in a friend invalid (authored by ychen). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen added a comment. @aaron.ballman Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! The failing precommit CI tests look to be unrelated to this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen updated this revision to Diff 394352. ychen added a comment. - format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 Files: clang/lib/Sema/SemaDecl.cpp clang/test/CXX/temp/temp.spec/temp.expl.s

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen updated this revision to Diff 394351. ychen added a comment. - Address Aaron's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 Files: clang/lib/Sema/SemaDecl.cpp clang/test/CXX/temp/te

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

aaron.ballman added a comment. Thanks for the fix for this -- I think the changes look like they're correct, but the test coverage needs a bit of work. Comment at: clang/lib/Sema/SemaDecl.cpp:9191 << FixItHint::CreateInsertion(InsertLoc, "<>"); + NewFD->s

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen added a comment. Hi @aaron.ballman, does this make sense to you? Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 ___ cfe-commits mailing list cfe-

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen added a comment. ping:-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113245/new/ https://reviews.llvm.org/D113245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D113245: [Sema] Mark explicit specialization declaration in a friend invalid

ychen created this revision. ychen added reviewers: rsmith, Mordante. ychen requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Down the path, if there is a implicit instantiation, this may trigger the assertion "Member specialization must be a