This revision was automatically updated to reflect the committed changes.
Closed by commit rG16b07c866ae7: [clang-tidy] Add check for initialization of
`absl::Cleanup`. (authored by CJ-Johnson, committed by ymandel).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://revie
CJ-Johnson updated this revision to Diff 385489.
CJ-Johnson added a comment.
Fix documentation nit
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113195/new/
https://reviews.llvm.org/D113195
Files:
clang-tools-extra/clang-tidy/abseil/AbseilTidyMo
CJ-Johnson updated this revision to Diff 385487.
CJ-Johnson added a comment.
Address nits and update the absl::Cleanup stub to be accurate with the real
interface (with associated changes to the AST matcher)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm
CJ-Johnson marked 4 inline comments as done.
CJ-Johnson added a comment.
Thanks for the review! I'll apply the same fixes to the string_view diff as well
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113195/new/
https://reviews.llvm.org/D113195
__
ymandel accepted this revision.
ymandel added a comment.
This revision is now accepted and ready to land.
Nice!
Comment at: clang-tools-extra/clang-tidy/abseil/CleanupCtadCheck.cpp:19
+
+using namespace clang::ast_matchers;
+using namespace ::clang::transformer;
---