[PATCH] D113115: Add diagnostic groups for attribute extensions

2021-12-07 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman closed this revision. aaron.ballman added a comment. I've committed (with a release note) in a18632adc884397e0cd7f27bdb8ea3a822b63000 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D113115: Add diagnostic groups for attribute extensions

2021-11-03 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. In D113115#3106360 , @erichkeane wrote: > I like the approach, and a pretty trivial implementation. Thanks for the review! I'm going to hold off on landing for a little bit in case @rsmith has opinions because he had othe

[PATCH] D113115: Add diagnostic groups for attribute extensions

2021-11-03 Thread Erich Keane via Phabricator via cfe-commits
erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. I like the approach, and a pretty trivial implementation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113115/new/ https://reviews.llvm

[PATCH] D113115: Add diagnostic groups for attribute extensions

2021-11-03 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, rjmccall, jyknight, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. Some users have a need to control attribute extension diagnostics independent of other extension diagnostics.