[PATCH] D112971: [NFC] Remove LinkAll*.h

aeubanks added a comment. the comments were misleading, I updated them in D113074 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112971/new/ https://reviews.llvm.org/D112971 __

[PATCH] D112971: [NFC] Remove LinkAll*.h

dblaikie added a comment. In D112971#3117441 , @dblaikie wrote: > My understanding is that this is necessary for the legacy pass manager that > uses a global registration system - if you didn't reference any function in > the pass, then the code wouldn'

[PATCH] D112971: [NFC] Remove LinkAll*.h

dblaikie added a comment. My understanding is that this is necessary for the legacy pass manager that uses a global registration system - if you didn't reference any function in the pass, then the code wouldn't get linked in - because the only way the pass was accessed was through the registry?

[PATCH] D112971: [NFC] Remove LinkAll*.h

aeubanks added a comment. Turns out the comments are misleading, they aren't to prevent specific functions from being removed, they're to force an odr usage of various functions, which in turn makes sure that globals in the corresponding translation units with the function definition are initia

[PATCH] D112971: [NFC] Remove LinkAll*.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe364e5dc78c: [NFC] Remove LinkAll*.h (authored by aeubanks). Herald added a subscriber: awarzynski. Changed prior to commit: https://reviews.llvm.

[PATCH] D112971: [NFC] Remove LinkAll*.h

MaskRay accepted this revision. MaskRay added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112971/new/ https://reviews.llvm.org/D112971

[PATCH] D112971: [NFC] Remove LinkAll*.h

aeubanks created this revision. Herald added a subscriber: hiraditya. aeubanks requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a reviewer: jdoerfert. Herald added a reviewer: sstefan1. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added a