[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7d6c2e18114d: [clang] Use llvm.is_fpclass to implement FP classification functions (authored by sepavloff). Changed prior to commit: https://revie

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

qiucf added a comment. Is there any blocker for this to land? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ https://reviews.llvm.org/D112932 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm added a comment. Description now needs updating since this diff no longer adds all the split out pieces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ https://reviews.llvm.org/D112932

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/test/CodeGen/isfpclass.c:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -S -O1 -emit-llvm %s -o - | FileCheck %s + +inline __attribute__((always_inlin

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

sepavloff updated this revision to Diff 529156. sepavloff added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Add createIsFPClass to IRBuilder Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ h

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:2185-2187 + auto TestV = llvm::ConstantInt::get(CGF->Int32Ty, Test); + Function *F = CGF->CGM.getIntrinsic(Intrinsic::is_fpclass, V->getType()); + return CGF->Builder.CreateCall(F, {V, TestV}); -

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm added a comment. In D112932#4005339 , @sepavloff wrote: > Remove __builtin_isfpclass I am interested in adding a __builtin_isfpclass, just in a separate patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm added a comment. In D112932#4043545 , @arsenm wrote: > This change itself LGTM but I think it should wait until after we get more > optimizations in to go back to fcmp, and after the release branch I think these optimizations are mostly in a good

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm added a comment. This change itself LGTM but I think it should wait until after we get more optimizations in to go back to fcmp, and after the release branch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ https://reviews.llvm.org

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

sepavloff updated this revision to Diff 488159. sepavloff added a comment. Remove support of __builtin_is{subnormal,zero,signaling}, rebased Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ https://reviews.llvm.org/D112932 Files: clang/

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:482-484 +BUILTIN(__builtin_issubnormal, "i.", "FnctE") +BUILTIN(__builtin_iszero, "i.", "FnctE") +BUILTIN(__builtin_issignaling, "i.", "FnctE") Sorry, I should have clarified, a

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

sepavloff updated this revision to Diff 485307. sepavloff added a comment. Update patch - Rebase, - Add test that checks inlining. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ https://reviews.llvm.org/D112932 Files: clang/include/c

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm added a comment. This will produce worse codegen in many situations. I'm working on a stack of patches to convert is.fpclass back to fcmp when legal Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ https://reviews.llvm.org/D112932

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

sepavloff updated this revision to Diff 483994. sepavloff added a comment. Remove __builtin_isfpclass Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112932/new/ https://reviews.llvm.org/D112932 Files: clang/include/clang/Basic/Builtins.def clan

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. Herald added a subscriber: wdng. I think the __builtin_isfpclass part should be a separate patch from the rest of the functions. Also needs sema tests for the handling of the immediat

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

sepavloff added inline comments. Comment at: clang/test/CodeGen/strictfp_builtins.c:160 +// CHECK-NEXT:[[TMP1:%.*]] = call double @llvm.fabs.f64(double [[TMP0]]) #[[ATTR5]] +// CHECK-NEXT:[[ISINF:%.*]] = call i1 @llvm.experimental.constrained.fcmp.f64(double [[TMP1]], d

[PATCH] D112932: Use llvm.is_fpclass to implement FP classification functions

kpn added inline comments. Comment at: clang/test/CodeGen/strictfp_builtins.c:160 +// CHECK-NEXT:[[TMP1:%.*]] = call double @llvm.fabs.f64(double [[TMP0]]) #[[ATTR5]] +// CHECK-NEXT:[[ISINF:%.*]] = call i1 @llvm.experimental.constrained.fcmp.f64(double [[TMP1]], double