[PATCH] D112926: run-clang-tidy.py analyze unique files only

This revision was automatically updated to reflect the committed changes. Closed by commit rG0dc856ed20e0: [clang-tidy] run-clang-tidy.py: analyze unique files only (authored by serkazi, committed by salman-javed-nz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D112926: run-clang-tidy.py analyze unique files only

serkazi added a comment. In D112926#3113220 , @salman-javed-nz wrote: > In D112926#3113206 , @serkazi wrote: > >> This is now accepted, please feel free to merge on my behalf. Thanks. > > What's the full name and

[PATCH] D112926: run-clang-tidy.py analyze unique files only

salman-javed-nz added a comment. In D112926#3113206 , @serkazi wrote: > This is now accepted, please feel free to merge on my behalf. Thanks. What's the full name and email you want associated with your commit? CHANGES SINCE LAST ACTION https://revie

[PATCH] D112926: run-clang-tidy.py analyze unique files only

serkazi added a comment. In D112926#3108140 , @salman-javed-nz wrote: > It looks good to me. I don't have any more comments to add - it is a very > small code change after all. > I have commit access and am happy to commit it on your behalf. > > However

[PATCH] D112926: run-clang-tidy.py analyze unique files only

lebedev.ri added a comment. In D112926#3108745 , @kuhar wrote: > I think this change is fine. > One could argue that having multiple files is an issue with tooling/build > system in the first place, No, why would that be a bug in itself? It may be a

[PATCH] D112926: run-clang-tidy.py analyze unique files only

kuhar accepted this revision. kuhar added a comment. This revision is now accepted and ready to land. I think this change is fine. One could argue that having multiple files is an issue with tooling/build system in the first place, and we could consider printing a warning instead of silently fi

[PATCH] D112926: run-clang-tidy.py analyze unique files only

serkazi added a comment. In D112926#3108140 , @salman-javed-nz wrote: > It looks good to me. I don't have any more comments to add - it is a very > small code change after all. > I have commit access and am happy to commit it on your behalf. > > However

[PATCH] D112926: run-clang-tidy.py analyze unique files only

salman-javed-nz added a comment. It looks good to me. I don't have any more comments to add - it is a very small code change after all. I have commit access and am happy to commit it on your behalf. However, this would be my first time as a reviewer, and I don't want to be presumptuous and appr

[PATCH] D112926: run-clang-tidy.py analyze unique files only

serkazi added a comment. In D112926#3102417 , @salman-javed-nz wrote: > Why does the compile-commands.json have duplicate entries in the first place? > Would someone do that on purpose? Think of a large project where people -- for various reasons -- do

[PATCH] D112926: run-clang-tidy.py analyze unique files only

salman-javed-nz added a comment. Why does the compile-commands.json have duplicate entries in the first place? Would someone do that on purpose? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112926/new/ https://reviews.llvm.org/D112926 ___ c

[PATCH] D112926: run-clang-tidy.py analyze unique files only

serkazi updated this revision to Diff 383959. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112926/new/ https://reviews.llvm.org/D112926 Files: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py Index