chapuni added a subscriber: chapuni.
chapuni added a comment.
Would this cause bunch of failures if target is *-ps4 and SDK_DIR is empty?
clang-3.8: error: unable to find PS4 system headers directory, expected to be
in
'/home/buildbot/Buildbot/Slave/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/
This revision was automatically updated to reflect the committed changes.
Closed by commit rL248546: This patch adds missing pieces to clang, including
the PS4 toolchain (authored by kromanova).
Changed prior to commit:
http://reviews.llvm.org/D11279?vs=34522&id=35681#toc
Repository:
rL LLVM
silvas added a subscriber: silvas.
silvas added a comment.
Once this lands, I think we can revert r247977
http://reviews.llvm.org/D11279
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
echristo added a comment.
In http://reviews.llvm.org/D11279#247402, @kromanova wrote:
> Hi Eric,
> I don't mind changing .keep into README. However, originally we did it for
> consistency purpose. If you grep for .keep in
> /llvm/tools/clang/test/Driver/Inputs directory, you will find hundreds
kromanova added a comment.
Hi Eric,
I don't mind changing .keep into README. However, originally we did it for
consistency purpose. If you grep for .keep in
/llvm/tools/clang/test/Driver/Inputs directory, you will find hundreds of
instances of these files that were created for similar reasons (
echristo added a comment.
In http://reviews.llvm.org/D11279#247377, @kromanova wrote:
> test/Driver/Inputs/scei-ps4_tree/target/include_common/ and
> test/Driver/Inputs/scei-ps4_tree/target/include/ are expected to be present
> by a test ps4-header-search.c. This test checks that these directo
kromanova added a comment.
test/Driver/Inputs/scei-ps4_tree/target/include_common/ and
test/Driver/Inputs/scei-ps4_tree/target/include/ are expected to be present by
a test ps4-header-search.c. This test checks that these directories are found
in the header search path. If these directories ar
echristo accepted this revision.
echristo added a comment.
One set of inline comments, and also:
test/Driver/Inputs/scei-ps4_tree/target/include_common/.keep
eh?
-eric
Comment at: lib/Driver/Tools.cpp:10025-10029
@@ +10024,7 @@
+ const char *Exec =
+#ifdef LLVM_ON_WIN32
+
filcab updated this revision to Diff 34522.
filcab marked 12 inline comments as done.
filcab added a comment.
This revision is now accepted and ready to land.
Addressed review comments.
http://reviews.llvm.org/D11279
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/Di
jroelofs added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:340
@@ +339,3 @@
+BaseSDKPath = P.str();
+ }
+}
kromanova wrote:
> jroelofs wrote:
> > The lifetime of `P` ends here, yet a reference to it lives on because of
> > the
kromanova added inline comments.
Comment at: lib/Driver/Tools.cpp:3590-3591
@@ -3580,4 +3589,4 @@
Args.ClaimAllArgs(options::OPT_g_flags_Group);
if (Args.hasFlag(options::OPT_gcolumn_info, options::OPT_gno_column_info,
- /*Default*/ true))
+
kromanova added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:340
@@ +339,3 @@
+BaseSDKPath = P.str();
+ }
+}
jroelofs wrote:
> The lifetime of `P` ends here, yet a reference to it lives on because of the
> `= P.str()`. Using it
jroelofs added a subscriber: jroelofs.
Comment at: lib/Frontend/InitHeaderSearch.cpp:340
@@ +339,3 @@
+BaseSDKPath = P.str();
+ }
+}
The lifetime of `P` ends here, yet a reference to it lives on because of the `=
P.str()`. Using it later on line
kromanova added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:325-344
@@ +324,22 @@
+ case llvm::Triple::PS4: {
+// gets prepended later in AddPath().
+std::string BaseSDKPath = "";
+if (!HasSysroot) {
+ const char *envValue = getenv("SCE_PS4_SD
echristo added a comment.
Replying to the inline comments. I know we're waiting on the linker stuff, but
Katya made me realize I hadn't replied to your comments.
-eric
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:203-208
@@ +202,8 @@
+ InGroup;
+def warn_drv_ps4_s
kromanova added inline comments.
Comment at: lib/Frontend/InitHeaderSearch.cpp:325-344
@@ +324,22 @@
+ case llvm::Triple::PS4: {
+// gets prepended later in AddPath().
+std::string BaseSDKPath = "";
+if (!HasSysroot) {
+ const char *envValue = getenv("SCE_PS4_SD
16 matches
Mail list logo
