This revision was automatically updated to reflect the committed changes.
Closed by commit rG32f102912493: [clangd] Track performance of IncludeCleaner
(authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112783/new/
https://reviews
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
oops forgot to LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112783/new/
https://reviews.llvm.org/D112783
___
kbobyrev updated this revision to Diff 383278.
kbobyrev marked 2 inline comments as done.
kbobyrev added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112783/new/
https://reviews.llvm.org/D112783
Files:
clang-
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:275
std::vector computeUnusedIncludes(ParsedAST &AST) {
+ trace::Span Tracer("IncludeCleaner::computeUnusedIncludes");
const auto &SM = AST.getSourceManager();
this doesn
kbobyrev created this revision.
kbobyrev added a reviewer: kadircet.
Herald added subscribers: usaxena95, arphaman.
kbobyrev requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Repository:
rG LLVM Github Mon
