[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

This revision was automatically updated to reflect the committed changes. Closed by commit rG290cddcd139d: Allow __attribute__((swift_attr)) in attribute push pragmas (authored by beccadax, committed by arphaman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

arphaman added a comment. I will commit this on behalf of @beccadax as she doesn't have commit access yet. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112773/new/ https://reviews.llvm.org/D112773 ___ c

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

aaron.ballman added a comment. In D112773#3137338 , @aaron.ballman wrote: > Thank you for diving into those details! I'm now sold on the idea that `any` > with no subjects is dangerous and we will diagnose if the user tries this. So > I think the only

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D112773#3135975 , @beccadax wrote: >> My reading of >> https://clang.llvm.org/docs/LanguageExtensions.html#specifying-an-attribute-fo

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

beccadax added a comment. > My reading of > https://clang.llvm.org/docs/LanguageExtensions.html#specifying-an-attribute-for-multiple-declarations-pragma-clang-attribute > suggests that any() /could/ apply to everything. (`The any rule applies > attributes to all declarations that are matched by

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

aaron.ballman added a comment. In D112773#3097730 , @beccadax wrote: > In D112773#3096185 , @aaron.ballman > wrote: > >> `swift_attr` has no subjects, so this will attempt to spray the attribute >> onto literall

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

beccadax added a comment. In D112773#3096185 , @aaron.ballman wrote: > `swift_attr` has no subjects, so this will attempt to spray the attribute > onto literally *everything*. That makes this incredibly risky to use with the > pragma approach (not to m

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

aaron.ballman requested changes to this revision. aaron.ballman added a comment. This revision now requires changes to proceed. `swift_attr` has no subjects, so this will attempt to spray the attribute onto literally *everything*. That makes this incredibly risky to use with the pragma approach

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

arphaman accepted this revision. arphaman added a comment. This revision is now accepted and ready to land. Looks good to me. Can you post the patch with the full context next time so that it's easier to review? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D112773: Allow __attribute__((swift_attr)) in attribute push pragmas

beccadax created this revision. beccadax added a reviewer: arphaman. beccadax added a project: clang. Herald added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. beccadax requested review of this revision. Herald added a subscriber: cfe-commits. This change does what it says on t