This revision was automatically updated to reflect the committed changes.
Closed by commit rGbd8a9507ef8c: [clang][driver] Fix multiarch output name with
-Wl arg (authored by keith).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112767/new/
https://
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112767/new/
https://reviews.llvm.org/D112767
___
keith updated this revision to Diff 383213.
keith marked an inline comment as done.
keith added a comment.
Update comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112767/new/
https://reviews.llvm.org/D112767
Files:
clang/lib/Driver/Driver.c
kastiglione added inline comments.
Comment at: clang/lib/Driver/Driver.cpp:4697
// Always use the first input as the base input.
const char *BaseInput = InputInfos[0].getBaseInput();
maybe adjust this comment to emphasize first _file_ input
Repository:
keith created this revision.
keith added reviewers: ddunbar, JDevlieghere.
keith requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Previously if you passed a `-Wl,-foo` _before_ the source filename, the
first `InputInfos`, which is used for t