[PATCH] D112730: [clang-tidy] Add AUTOSAR module

lattner added a comment. Thank you so much Carlos, I hope they can come to see the value of having first class support for this in LLVM/Clang. I really appreciate you pushing for this, -Chris CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp abandoned this revision. carlosgalvezp added a comment. Understood, thanks a lot for the clarification and for the time taken! I will then abandon this patch given the high risk involved. I will forward this feedback to MISRA in case there is a possibility to publish the upcoming

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

lattner added a comment. Hi all, I'm commenting on this based on my personal opinion, I don't speak for the LLVM board or anyone else. I am also not a lawyer :) This isn’t a clear cut case (as is typical!). LLVM's approach on patents protection revolves primarily around the terms in the Apach

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. In D112730#3316646 , @carlosgalvezp wrote: > Thanks a lot @tonic for your update and for the work done in the last months > ! It's indeed very sad to hear the news. It's a pity that the work will > probably be duplicated

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. Thanks a lot @tonic for your update and for the work done in the last months ! It's indeed very sad to hear the news. It's a pity that the work will probably be duplicated in many local forks with sub-optimal solutions instead of a centralized, high-quality, peer-

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

tonic added a comment. Unfortunately our legal counsel has advised that this patch should not be included into LLVM because the exact patent burden is not disclosed. Therefore, we can not accept this patch into LLVM. I am very sorry to have to report this disappointing news. CHANGES SINCE LAS

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. @tstellar Do you have any updates on the topic? What approximate time frame should I expect? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730 ___ cfe-commits ma

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. @tstellar I totally missed your fast reply, sorry about that! I have just forwarded the mail chain to the indicated address. Let me know if there's anything else I can do to help. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. Btw can't we just have a license disclaimer like it's done for HiCPP? https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clang-tidy/hicpp/LICENSE.TXT CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

tstellar added a comment. In D112730#3133822 , @carlosgalvezp wrote: > @tstellar @tonic I have finally received an answer from AUTOSAR. Let me know > if you'd like me to CC you the mail chain to see the exact discussion. Can you cc bo...@llvm.org on th

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. @tstellar @tonic I have finally received an answer from AUTOSAR. Let me know if you'd like me to CC you the mail chain to see the exact discussion. > The AUTOSAR confidential statement states that these documents are considered > under the license of AUTOSAR, thus

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. In D112730#3116281 , @tstellar wrote: > @carlosgalvezp The LLVM Foundation Board will conduct a legal reivew of this > patch. Would you be able to share any information you have about the license > or usage restrictions f

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

tstellar added a comment. @carlosgalvezp The LLVM Foundation Board will conduct a legal reivew of this patch. Would you be able to share any information you have about the license or usage restrictions for the AUTOSAR specification? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. In D112730#3097091 , @tstellar wrote: > @carlosgalvezp Did you write this patch or did you get it from someone else? @tstellar I wrote it myself (following the existing pattern for the other modules in the llvm-project rep

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

tstellar requested changes to this revision. tstellar added a comment. This revision now requires changes to proceed. @carlosgalvezp Did you write this patch or did you get it from someone else? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. > people DO incorporate clang-tidy into their own commercial offerings Gna, that //can// be a problem. I wonder if in that case it would be possible to add a few lines into the `LLVM Exceptions` part of the license. If it's too much of a hassle I guess I'll need t

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

aaron.ballman added reviewers: alexfh, tonic. aaron.ballman added a subscriber: tonic. aaron.ballman added a comment. In D112730#3095767 , @carlosgalvezp wrote: > Also, I've sent a mail to AUTOSAR directly asking for consent, so there's no > doubt. Tha

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. Also, I've sent a mail to AUTOSAR directly asking for consent, so there's no doubt. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730 ___ cfe-commits mailing list cfe-co

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp updated this revision to Diff 383259. carlosgalvezp added a comment. Removed unnecessary dependency in CMakeLists.txt CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-to

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp added a comment. > "C++14 Guidelines"? So it's always and definitely C++14 specific? To my knowledge, AUTOSAR handed over the work to MISRA and the current direction is that MISRA will merge AUTOSAR C++14 and older MISRA revisions into a brand-new MISRA release, coming up 202x (Th

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

whisperity added a comment. "C++14 Guidelines"? So it's always and definitely C++14 specific? What is the licencing approach of this guideline? Looking up with searchers seems to turn up a few PDFs which say `--- AUTOSAR CONFIDENTIAL ---`, yet they are up and out on the official-looking website

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp updated this revision to Diff 383087. carlosgalvezp added a comment. Update release notes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-extra/clang-tidy/ClangT

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp updated this revision to Diff 383059. carlosgalvezp added a comment. Fix ordering in check list. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-extra/clang-tidy/

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp updated this revision to Diff 383058. carlosgalvezp added a comment. Specify C++14 in the module description. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112730/new/ https://reviews.llvm.org/D112730 Files: clang-tools-extra/clang-tidy/CMakeLists.txt clang-tools-extr

[PATCH] D112730: [clang-tidy] Add AUTOSAR module

carlosgalvezp created this revision. carlosgalvezp added reviewers: aaron.ballman, whisperity. carlosgalvezp added a project: clang-tools-extra. Herald added subscribers: armkevincheng, jsmolens, eric-k256, arphaman, rnkovacs, kbarton, xazax.hun, mgorny, nemanjai. Herald added a reviewer: sjarus.