This revision was automatically updated to reflect the committed changes.
kadircet marked an inline comment as done.
Closed by commit rG3d735480bd2a: [clangd] SelectionTree should prefer lexical
declcontext (authored by kadircet).
Changed prior to commit:
https://reviews.llvm.org/D112712?vs=383
kadircet marked 3 inline comments as done.
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:751
+ {
+auto ST = SelectionTree::createRight(AST.getASTContext(), AST.getTokens(),
+ Test.poi
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/Selection.cpp:893
const DeclContext &SelectionTree::Node::getDeclContext() const {
for (const Node *CurrentNode = this; C
kadircet updated this revision to Diff 383008.
kadircet edited the summary of this revision.
kadircet added a comment.
- Related https://github.com/clangd/clangd/issues/900.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112712/new/
https://reviews.
kadircet created this revision.
kadircet added a reviewer: sammccall.
Herald added subscribers: usaxena95, arphaman.
kadircet requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This is important especially fo
