[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

ronlieb added a comment. Herald added subscribers: kosarev, mattd. Herald added a project: All. @JonChesterfield i am seeing the testcase bug50022.cpp occasionally randomly failing in amdgpu bbot most recently: https://lab.llvm.org/buildbot/#/builders/193/builds/24230 the same bbot in Stagin

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27177b82d4ca: [OpenMP] Lower printf to __llvm_omp_vprintf (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield updated this revision to Diff 386156. JonChesterfield added a comment. - regen test file using the better './llvm/utils/update_cc_test_checks.py --llvm-bin=/home/amd/llvm-install/bin clang/test/OpenMP/nvptx_target_printf_codegen.c', now passing Repository: rG LLVM Github Mono

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield updated this revision to Diff 385614. JonChesterfield added a comment. - ./llvm/utils/update_cc_test_checks.py clang/test/OpenMP/nvptx_target_printf_codegen.c --opt=$HOME/llvm-install/bin/opt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

Conanap added a comment. thanks for reverting! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/ https://reviews.llvm.org/D112680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a comment. This passed the openmp buildbot but failed some others, e.g. clang-armv7-quick/llvm/clang/test/OpenMP/nvptx_target_printf_codegen.c:64:19: error: CHECK-64-NEXT: expected string not found in input // CHECK-64-NEXT: [[TMP6:%.*]] = call i32 @vprintf(i8* [[TMP1

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

Conanap added a comment. Hello, looks like this commit might be causing some failures on PowerPC buildbots, would you be able to take a quick look? Failing test case is `Clang :: OpenMP/nvptx_target_printf_codegen.c`. Buildbot link: https://lab.llvm.org/buildbot/#/builders/105/builds/17248/st

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdb81d8f6c4d6: [OpenMP] Lower printf to __llvm_omp_vprintf (authored by JonChesterfield). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a comment. Folded EmitOpenMPDevicePrintfCallExpr and EmitNVPTXDevicePrintfCallExpr into asserts plus one line call into a common function. Leaving amdgpu alone in this patch as it's doing something odd with getScalarVal and I don't want to run this through the internal CI

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield updated this revision to Diff 385525. JonChesterfield added a comment. - fold nvptx and openmp printf into one call - Drop ReturnValue argument Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/ https://reviews.llvm.org/D1126

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a subscriber: ronlieb. JonChesterfield added a comment. Updated. Left Builder.CreateCall alone as I've failed to think of a clean way to handle the sometimes present size argument. Tests pass locally and are a credible guess at what will pass the CI bot, but may need to rol

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield updated this revision to Diff 385512. JonChesterfield added a comment. - helper for nonscalars Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/ https://reviews.llvm.org/D112680 Files: clang/lib/CodeGen/CGBuiltin.cpp cl

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield updated this revision to Diff 385505. JonChesterfield added a comment. - rebase, static functions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/ https://reviews.llvm.org/D112680 Files: clang/lib/CodeGen/CGBuiltin.cpp

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a comment. Thanks for the review! Couple of helpers to split out and the rebase on main is messy, retesting now Comment at: clang/lib/CodeGen/CGGPUBuiltin.cpp:231 + VprintfFunc, {Args[0].getRValue(*this).getScalarVal(), BufferPtr, Size})); +} --

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, one nit. Comment at: clang/lib/CodeGen/CGGPUBuiltin.cpp:231 + VprintfFunc, {Args[0].getRValue(*this).getScalarVal(), BufferPtr, Size})); +} S

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/ https://reviews.llvm.org/D112680 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a comment. New runtime failing CI suggests it may take some iteration to land, so reworked this to make sense with or without it. Doesn't make much difference to nvptx - printf still ultimately resolves to the same vprintf function as before - but a lot of tests that were

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield updated this revision to Diff 382873. JonChesterfield added a comment. - rebase to not require new runtime, stubs now return error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112680/new/ https://reviews.llvm.org/D112680 Files:

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield added a comment. Makes more sense with D112227 landed, but probably worthwhile just for the old runtime as it removes the link failure from all the tests that use printf. Comment at: clang/lib/CodeGen/CGGPUBuiltin.cpp:94 +std

[PATCH] D112680: [OpenMP] Lower printf to __llvm_omp_vprintf

JonChesterfield created this revision. JonChesterfield added reviewers: jdoerfert, tianshilei1992, jhuber6, ye-luo, ronlieb, pdhaliwal. Herald added subscribers: asavonic, kerbowa, guansong, tpr, yaxunl, mgorny, nhaehnle, jvesely. JonChesterfield requested review of this revision. Herald added su