[PATCH] D112659: Add a limit to __make_integer_seq builtin.

2021-10-28 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. In D112659#3091501 , @rsmith wrote: > I wonder if more generally we should have a limit on either the size of a > pack or the number of template arguments in a template specialization, rather > than limiting only `__make_inte

[PATCH] D112659: Add a limit to __make_integer_seq builtin.

2021-10-27 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith added a comment. I wonder if more generally we should have a limit on either the size of a pack or the number of template arguments in a template specialization, rather than limiting only `__make_integer_seq`? I think a hand-rolled `make_integer_sequence` implementation should also be li

[PATCH] D112659: Add a limit to __make_integer_seq builtin.

2021-10-27 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a subscriber: ldionne. erichkeane added a comment. Some additional data on a release build (on my quite recent Xeon 8260M): 2^24: 27 sec, ~3.3GB 2^25: 49 sec, ~6.4GB It follows a pretty linear pattern from there. I'm open to choosing a different limit if we find one more reaso

[PATCH] D112659: Add a limit to __make_integer_seq builtin.

2021-10-27 Thread Erich Keane via Phabricator via cfe-commits
erichkeane created this revision. erichkeane added reviewers: aaron.ballman, majnemer, EricWF. Herald added subscribers: dexonsmith, dang. erichkeane requested review of this revision. As brought up in PR48246, passing a large value to `__make_integer_seq` results in the compiler getting stuck in