usaxena95 added a comment.
No worries. Thanks for taking a look :)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112530/new/
https://reviews.llvm.org/D112530
___
cfe-commits mailing list
cfe-commits@list
kadircet added a comment.
(oops, i didn't notice i wasn't the reviewer :D)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112530/new/
https://reviews.llvm.org/D112530
___
cfe-commits mailing list
cfe-comm
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG2174524116a8: [clangd] AddUsing: Fix support for template
specializations. (authored by adamcz).
Repository:
rG LLVM Github Monorepo
CHANGES SINC
adamcz updated this revision to Diff 382335.
adamcz added a comment.
review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112530/new/
https://reviews.llvm.org/D112530
Files:
clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp
clang-
adamcz removed a reviewer: usaxena95.
adamcz added a comment.
Thanks Kadir!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112530/new/
https://reviews.llvm.org/D112530
___
cfe-commits mailing list
cfe-com
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
Comment at: clang-tools-extra/clangd/refactor/tweaks/AddUsing.cpp:284
+// Remove the template arguments from the name.
+NameRange = SourceRange(Na
adamcz created this revision.
Herald added subscribers: usaxena95, kadircet, arphaman.
adamcz requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
Before this change, we would add "using std::vector" instead of
