[PATCH] D112527: [clangd] Fix a hover crash on templated spaceship operator.

2021-10-26 Thread Adam Czachorowski via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe8f4a0118914: [clangd] Fix a hover crash on templated spaceship operator. (authored by adamcz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112527/new/ ht

[PATCH] D112527: [clangd] Fix a hover crash on templated spaceship operator.

2021-10-26 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz updated this revision to Diff 382326. adamcz marked 2 inline comments as done. adamcz added a comment. review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112527/new/ https://reviews.llvm.org/D112527 Files: clang-tools-extra/cla

[PATCH] D112527: [clangd] Fix a hover crash on templated spaceship operator.

2021-10-26 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added inline comments. This revision is now accepted and ready to land. Comment at: clang-tools-extra/clangd/Hover.cpp:271 + DeclForComment = TSD->getSpecializedTemplate(); if (const auto *TIP = TSD->getTemplateInstantiationPatt

[PATCH] D112527: [clangd] Fix a hover crash on templated spaceship operator.

2021-10-26 Thread Adam Czachorowski via Phabricator via cfe-commits
adamcz created this revision. adamcz added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman, yaxunl. adamcz requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. We make assumption that: getDe