[PATCH] D112498: [Lex] Remove timer from #pragma clang __debug crash handler

aganea added a comment. That sounds right. You can test that scenario in a debugger, by putting a breakpoint before BuryPointer in clang/tools/driver/driver.cpp and verifying that the TimerGroup still has a pointer to the deleted stack frames, after the CrashRecoveryContext has successfully cat

[PATCH] D112498: [Lex] Remove timer from #pragma clang __debug crash handler

sammccall added a comment. In D112498#3086029 , @aganea wrote: > This Timer is actually the test coverage for that commit. Ah, our issue is that it runs in production as well as in the tests. Each time the parser sees the crash pragma it dumps a bunch o

[PATCH] D112498: [Lex] Remove timer from #pragma clang __debug crash handler

aganea added a comment. This Timer is actually the test coverage for that commit. If we don’t want it here, I guess you could move it to the Support unit tests? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112498/new/ https://reviews.llvm.org/D11

[PATCH] D112498: [Lex] Remove timer from #pragma clang __debug crash handler

sammccall created this revision. sammccall added reviewers: kadircet, aganea. sammccall requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This seems to be temporary code for testing 28ad9fc20823678881baa0d723834b88ea9e8e3a