[PATCH] D112492: [HIP] Do not use kernel handle for MSVC target

tra added a comment. > With these changes, we should have consistent name mangling for kernel stubs > and kernel launching mechanism on Linux and Windows. Nice! Thank you for figuring out the root causes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112492/new/ https://reviews.llvm.o

[PATCH] D112492: [HIP] Do not use kernel handle for MSVC target

yaxunl added a comment. In D112492#3101090 , @tra wrote: > As phrased, the summary would likely be rather confusing for anyone other > than you and me. > >> Currently Visual Studio 2019 has a linker issue which causes linking error >> when a template ker

[PATCH] D112492: [HIP] Do not use kernel handle for MSVC target

tra added a comment. As phrased the summary would likely be rather confusing for anyone other than you and me. > Currently Visual Studio 2019 has a linker issue which causes linking error > when a template kernel is instantiated in different compilation units. It's not clear what exactly is the

[PATCH] D112492: [HIP] Do not use kernel handle for MSVC target

yaxunl added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112492/new/ https://reviews.llvm.org/D112492 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D112492: [HIP] Do not use kernel handle for MSVC target

yaxunl created this revision. yaxunl added a reviewer: tra. yaxunl requested review of this revision. Currently Visual Studio 2019 has a linker issue which causes linking error when a template kernel is instantiated in different compilation units. On the other hand, it is unnecessary to prefix ker