DavidSpickett added inline comments.
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5745
+ IIC_Br, [(ARMt2CallBTI tglobaladdr:$func)]>,
+ Requires<[IsThumb2]>, Sched<[WriteBrL]>;
DavidSpickett wrote:
> chill wrote:
> > DavidSpic
DavidSpickett added inline comments.
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5745
+ IIC_Br, [(ARMt2CallBTI tglobaladdr:$func)]>,
+ Requires<[IsThumb2]>, Sched<[WriteBrL]>;
chill wrote:
> DavidSpickett wrote:
> > Should th
chill added inline comments.
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5745
+ IIC_Br, [(ARMt2CallBTI tglobaladdr:$func)]>,
+ Requires<[IsThumb2]>, Sched<[WriteBrL]>;
DavidSpickett wrote:
> Should this require `IsMClass` ins
DavidSpickett added inline comments.
Comment at: llvm/lib/Target/ARM/ARMInstrThumb2.td:5745
+ IIC_Br, [(ARMt2CallBTI tglobaladdr:$func)]>,
+ Requires<[IsThumb2]>, Sched<[WriteBrL]>;
Should this require `IsMClass` instead/also? Thou
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0fbb17458a01: [ARM] Implement setjmp BTI placement for
PACBTI-M (authored by stuij).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTIO
stuij updated this revision to Diff 390633.
stuij added a comment.
slight rewording
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112427/new/
https://reviews.llvm.org/D112427
Files:
clang/docs/ClangCommandLineReference.rst
clang/include/clang/
stuij updated this revision to Diff 388891.
stuij added a comment.
Herald added subscribers: cfe-commits, dang.
Herald added a project: clang.
addressed review comments, namely adding a commandline argument,
`-mno-bti-at-return-twice`, to not place a bti instruction after a setjmp call.
Reposit
