[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia added a comment. In D112410#3208353 , @MaskRay wrote: > I slightly adjusted the test in eafc64ed6325eba962096d4a947d7e45e909bfde > :) > > `-no-canonical-prefixes` can usually

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

MaskRay added a comment. I slightly adjusted the test in eafc64ed6325eba962096d4a947d7e45e909bfde :) `-no-canonical-prefixes` can usually be omitted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0045d01af96f: [SPIR-V] Add a toolchain for SPIR-V in clang (authored by Anastasia). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia added a comment. In D112410#3197441 , @linjamaki wrote: > If I understand correctly, the default optimization level is `-O2` for the > OpenCL and OpenCL++ language mode (according to > CompilerInvocation.cpp:getOptimizationLevel()). Since high

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

linjamaki added a comment. If I understand correctly, the default optimization level is `-O2` for the OpenCL and OpenCL++ language mode (according to CompilerInvocation.cpp:getOptimizationLevel()). Since higher than `-O0` may not work with the translator, should the SPIR-V tool chain override t

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

svenvh accepted this revision. svenvh added a comment. This revision is now accepted and ready to land. Mostly some minor comments that you can address at commit time. It would be good to get approval from another reviewer. Comment at: clang/docs/UsersManual.rst:3538 +

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia updated this revision to Diff 394353. Anastasia added a comment. Addressed review comments from Sven: - Improved docs and code comments; - Simplified tests; - Added warning in a group. - Aligned with translator PRs after merge. Note, that this change now references documentation from P

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

svenvh added inline comments. Comment at: clang/test/Driver/spirv-toolchain.cl:10 +// SPV64-SAME: "-o" [[BC:".*bc"]] +// SPV64: {{".*llvm-spirv.*"}} [[BC]] "-o" {{".*o"}} + Anastasia wrote: > svenvh wrote: > > Any reason to not just check for `llvm-spirv{{.*}}`,

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia added inline comments. Comment at: clang/docs/UsersManual.rst:3559 +by the OpenCL driver that support SPIR-V consumption or it can be compiled further +by offline SPIR-V consumer tools. + Btw do we want to say anything about the limitations of translat

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

svenvh requested changes to this revision. svenvh added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Driver/Driver.cpp:3728 + // Linking separate translation units for SPIR-V is not supported yet. + // It can be done either by LLVM IR

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia updated this revision to Diff 391064. Anastasia added a comment. - Exported full diff. - Added forgotten test cases. - Fixed typo in docs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112410/new/ https://reviews.llvm.org/D112410 Files: clang/docs/UsersManual.rst clang/in

[PATCH] D112410: [SPIR-V] Add a toolchain for SPIR-V in clang

Anastasia updated this revision to Diff 391037. Anastasia retitled this revision from "[SPIR-V] Add a tool chain for SPIR-V (incomplete)" to "[SPIR-V] Add a toolchain for SPIR-V in clang". Anastasia edited the summary of this revision. Anastasia added reviewers: svenvh, azabaznov. Anastasia added