This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4f94c0261602: [Clang] Mutate bulitin names under IEEE128 on
PPC64 (authored by qiucf).
Changed prior to commit:
https://reviews.llvm.org/D112401?v
jsji accepted this revision as: jsji.
jsji added a comment.
This revision is now accepted and ready to land.
LGTM. Please hold a few days to see whether there are inputs from other
reviewers. Thanks.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:100
+ static SmallDenseMap F128B
qiucf added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:100
+ static SmallDenseMap F128Builtins{
+ {Builtin::BI__builtin_printf, "__printfieee128"},
+ {Builtin::BI__builtin_vsnprintf, "__vsnprintfieee128"},
jsji wrote:
> Why only these
qiucf updated this revision to Diff 383715.
qiucf added a comment.
Add `nexttoward`
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112401/new/
https://reviews.llvm.org/D112401
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/math-builtins-long.c
clang/test/CodeGen/ppc64-f
jsji added inline comments.
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:100
+ static SmallDenseMap F128Builtins{
+ {Builtin::BI__builtin_printf, "__printfieee128"},
+ {Builtin::BI__builtin_vsnprintf, "__vsnprintfieee128"},
Why only these printf builtin
qiucf updated this revision to Diff 381868.
qiucf added a reviewer: rjmccall.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112401/new/
https://reviews.llvm.org/D112401
Files:
clang/lib/CodeGen/CGBuiltin.cpp
clang/test/CodeGen/ppc64-f128-builtin
qiucf created this revision.
qiucf added reviewers: nemanjai, jsji, PowerPC.
Herald added subscribers: shchenz, kbarton.
qiucf requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Glibc uses these new symbol names to support IEEE-754 128-bit flo