[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

thakis added a comment. In D112287#3146956 , @comanea wrote: > I believe there is an issue that this change introduced. It is described > here. https://bugs.llvm.org/show_bug.cgi?id=52473 > If anyone could provide some insight, it would be much appreciat

[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

comanea added a comment. I believe there is an issue that this change introduced. It is described here. https://bugs.llvm.org/show_bug.cgi?id=52473 If anyone could provide some insight, it would be much appreciated. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG04f30795f166: [clang] Implement CFG construction for @try and @catch (authored by thakis). Herald added a project: clang. Changed prior to commit:

[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

thakis marked 4 inline comments as done. thakis added a comment. Thanks, all done. Looks like there's no range access to a try's catch blocks, so no for-range loop for now. Maybe I'll add range accessors for those later. Comment at: clang/lib/Analysis/CFG.cpp:3895 CFGBlock *

[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm, just some nits. Comment at: clang/lib/Analysis/CFG.cpp:485 - // This can point either to a try or a __try block. The frontend forbids - // mixing both kinds in one func

[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

thakis updated this revision to Diff 381450. thakis added a comment. clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112287/new/ https://reviews.llvm.org/D112287 Files: clang/lib/Analysis/CFG.cpp clang/test/Sema/warn-unreachable.m clang/test/Sema/warn-unreachable.mm

[PATCH] D112287: [clang] Implement CFG construction for @try and @catch

thakis created this revision. thakis added a reviewer: rnk. thakis requested review of this revision. @finally is still not implemented. With this, clang can emit -Wreturn-type warnings for functions containing @try/@catch (but not yet @finally), and -Wunreachable-code also works for those functi