[PATCH] D112284: [Clang][NFC] Clang CUDA codegen clean-up

bondhugula added a comment. In D112284#3088531 , @tra wrote: > In D112284#3086499 , @bondhugula > wrote: > >> @tra While on this, I also wanted to ask as to why clang cuda codegen is >> using an argument on the

[PATCH] D112284: [Clang][NFC] Clang CUDA codegen clean-up

This revision was automatically updated to reflect the committed changes. bondhugula marked an inline comment as done. Closed by commit rG9fb9c6b91e3a: [Clang][NFC] Clang CUDA codegen clean-up (authored by bondhugula). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D112284: [Clang][NFC] Clang CUDA codegen clean-up

tra added a comment. In D112284#3086499 , @bondhugula wrote: > @tra While on this, I also wanted to ask as to why clang cuda codegen is > using an argument on the global ctor and the dtor it's generating. It's a good question, and I don't have a good a

[PATCH] D112284: [Clang][NFC] Clang CUDA codegen clean-up

bondhugula added a comment. @tra While on this, I also wanted to ask as to why clang cuda codegen is using an argument on the global ctor and the dtor it's generating. The argument is unused and I couldn't find any code comments to support it in either `CGCUDANV.cpp` or `CodeGenModule.cpp`. I

[PATCH] D112284: [Clang][NFC] Clang CUDA codegen clean-up

bondhugula updated this revision to Diff 382201. bondhugula marked an inline comment as done. bondhugula retitled this revision from "[Clang][NFC] Clang CUDA codegen: a dyn_cast -> cast instance + clang-tidy fixes" to "[Clang][NFC] Clang CUDA codegen clean-up". bondhugula edited the summary of th