[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added a comment. Landed a slightly modified version of this - code and test changes are included, but the tests are not run by default. I'm hopeful this will help the process of working out why ~10 are failing on CI and passing locally. Repository: rG LLVM Github Monorepo CH

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

This revision was automatically updated to reflect the committed changes. Closed by commit rG4d50803ce49c: [libomptarget] Build DeviceRTL for amdgpu (authored by JonChesterfield). Changed prior to commit: https://reviews.llvm.org/D112227?vs=382866&id=382987#toc Repository: rG LLVM Github Mon

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added a reviewer: ronlieb. JonChesterfield added a comment. Tagging Ron as this is current stuck on the mystery of passing locally and failing CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D1

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield updated this revision to Diff 382866. JonChesterfield added a comment. - fix new+old test enabling Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D112227 Files: clang/lib/Driver/ToolChains/AMDG

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield updated this revision to Diff 382864. JonChesterfield added a comment. - Reintroduce syncThreadsAligned, dropped in git merge conflict Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D112227 Files

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Synchronization.cpp:196 -void syncThreadsAligned() { syncThreads(); } - -void fenceTeam(int Ordering) { __builtin_amdgcn_fence(Ordering, "workgroup"); } - -void fenceKernel(int Ordering) { __bu

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield reopened this revision. JonChesterfield added a comment. This revision is now accepted and ready to land. Didn't fare very well under CI, investigating. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

This revision was automatically updated to reflect the committed changes. Closed by commit rG33427fdb7b52: [libomptarget] Build DeviceRTL for amdgpu (authored by JonChesterfield). Changed prior to commit: https://reviews.llvm.org/D112227?vs=382446&id=382853#toc Repository: rG LLVM Github Mon

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

jdoerfert accepted this revision. jdoerfert added a comment. This revision is now accepted and ready to land. LG, I'll land my fix and with this we can switch over to the new RT. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://rev

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added a comment. Requires either D112544 or disabling bug51982 on newRTL before landing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D112227

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added a comment. Problem with missing symbol for __omp_rtl_debug_kind was a local error. I did the initial testing of this with a jury rigged clang that linked the new bitcode and ignored the old. The generation of this integer is guarded by which runtime clang thinks it is comp

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield updated this revision to Diff 382446. JonChesterfield added a comment. - rebase, having landed D111987 this time Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield updated this revision to Diff 382442. JonChesterfield added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D112227 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp open

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield updated this revision to Diff 382441. JonChesterfield added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D112227 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp open

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added a comment. I think this is good enough for now. It drops the not yet used debug variable and writes out the lowering for runtime values of memory ordering manually. The latter will be simplified once clang learns to emit the switch instead of error. Omp lock is a problem I

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield updated this revision to Diff 382433. JonChesterfield added a comment. - delete the extern debug_kind variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D112227 Files: clang/lib/Driver/Too

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield updated this revision to Diff 382430. JonChesterfield added a comment. - drop outdated comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D112227 Files: clang/lib/Driver/ToolChains/AMDGPUOp

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield updated this revision to Diff 382421. JonChesterfield added a comment. - Enable tests on amdgpu, with same ones marked xfail/unsupported as on the old runtime Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://review

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield updated this revision to Diff 382306. JonChesterfield added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112227/new/ https://reviews.llvm.org/D112227 Files: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp open

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added subscribers: ronlieb, pdhaliwal, carlo.bertolli, gregrodgers, dpalermo. JonChesterfield added a comment. Subscribed some AMD people to this. I wanted to apply this patch as-is to amd-stg-open to feed it to the internal testing, but it doesn't apply because Driver/ToolChain

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Configuration.cpp:23 -extern uint32_t __omp_rtl_debug_kind; +// extern uint32_t __omp_rtl_debug_kind; jdoerfert wrote: > JonChesterfield wrote: > > Otherwise the missing symb

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

jdoerfert added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Configuration.cpp:23 -extern uint32_t __omp_rtl_debug_kind; +// extern uint32_t __omp_rtl_debug_kind; JonChesterfield wrote: > Otherwise the missing symbols prevents linking, not c

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Configuration.cpp:23 -extern uint32_t __omp_rtl_debug_kind; +// extern uint32_t __omp_rtl_debug_kind; Otherwise the missing symbols prevents linking, not clear why it works o

[PATCH] D112227: [libomptarget] Build DeviceRTL for amdgpu

JonChesterfield created this revision. Herald added subscribers: kerbowa, t-tye, tpr, dstuttard, yaxunl, mgorny, nhaehnle, jvesely, kzhuravl. JonChesterfield requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1, wdng. Herald added a reviewer: jdoerfert