[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in 0d459444e5105d689e6388612784b89a93054944 , thanks all for the helpful reviews! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. Thanks @Quuxplusone! @rsmith, I plan to commit this (with the suggested fix to release notes applied) sometime on Fri (Jan 14) unless I hear further feedback, in case you want to weigh in. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https:

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

Quuxplusone accepted this revision. Quuxplusone added a comment. LGTM FWIW. I'm not the right person to approve for libc, but I'm not sure any of the currently listed reviewers are any more appropriate either. So you should find and ping a new reviewer, or just ship it, at your discretion. :)

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D112221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman updated this revision to Diff 397061. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updated release notes and user's manual based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D112221

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman marked 2 inline comments as done. aaron.ballman added inline comments. Comment at: clang/docs/ReleaseNotes.rst:159-164 + - The ``ATOMIC_VAR_INIT`` macro from is now diagnosed as + deprecated in both C (C17 and later) and C++ (C++20 and later), and + ``ATOMI

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

Quuxplusone added a comment. TLDR on `_CLANG_DISABLE_CRT_DEPRECATION_WARNINGS`: I'm neutral. :) Comment at: clang/docs/ReleaseNotes.rst:159-164 + - The ``ATOMIC_VAR_INIT`` macro from is now diagnosed as + deprecated in both C (C17 and later) and C++ (C++20 and later), an

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. Ping @Quuxplusone for feedback on the `_CLANG_DISABLE_CRT_DEPRECATION_WARNINGS` macro that was added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D112221 ___ cfe-commits m

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

ldionne added a comment. In D112221#3196740 , @tambre wrote: > In D112221#3195955 , @ldionne wrote: > >> @tambre Any appetite for a libc++ patch? :) >> >> Otherwise, let me know and I'll put it in my list of thing

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

tambre added a comment. In D112221#3195955 , @ldionne wrote: > @tambre Any appetite for a libc++ patch? :) > > Otherwise, let me know and I'll put it in my list of things to fix up. Sure, I can take it up during the weekend. CHANGES SINCE LAST ACTION

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

ldionne added a comment. @tambre Any appetite for a libc++ patch? :) Otherwise, let me know and I'll put it in my list of things to fix up. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D112221 ___ cfe-co

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. In D112221#3195533 , @tambre wrote: > I only took care of `std::atomic_init()` and seemingly completely missed > cleaning up uses of `ATOMIC_VAR_INIT`. > I do remember not being able to add a deprecation notice for > `ATOM

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. In D112221#3195506 , @ldionne wrote: > Sorry, I seemed to have missed this entirely. No worries! > Since this is touching only `` and not libc++'s ``, I > think it would actually be OK not to make any changes at all insid

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman updated this revision to Diff 394626. aaron.ballman added a comment. Dropped changes to libc++ based on review feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D112221 Files: clang/docs/ReleaseNotes.rst clang/docs/UsersManua

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

tambre added a comment. In D112221#3195506 , @ldionne wrote: > Sorry, I seemed to have missed this entirely. > > Since this is touching only `` and not libc++'s ``, I > think it would actually be OK not to make any changes at all inside libc++. > Nothin

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

ldionne added a subscriber: tambre. ldionne added a comment. Sorry, I seemed to have missed this entirely. Since this is touching only `` and not libc++'s ``, I think it would actually be OK not to make any changes at all inside libc++. Nothing should break. We should separately implement P0883

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. In D112221#3195214 , @aaron.ballman wrote: > Thank you for the help here! FWIW, I'm not certain the libc++ tests need to > be changed at all -- shouldn't those all be using the macro definitions > obtained by libc++'s ``

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman updated this revision to Diff 394597. aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. Updated based on review feedback from Arthur. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D112221 Files: clang/doc

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman marked 2 inline comments as done. aaron.ballman added a comment. In D112221#3119567 , @Quuxplusone wrote: >> I don't know enough about libc++ to feel comfortable making those changes >> yet. For example, does libc++ need to work with other

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

Quuxplusone added a comment. > I don't know enough about libc++ to feel comfortable making those changes > yet. For example, does libc++ need to work with other compilers than Clang > (compilers which might give diagnostics if you fail to use ATOMIC_VAR_INIT in > some language mode)? The deprec

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. In D112221#3118314 , @Quuxplusone wrote: > If libc++ is using these macros, then I think it would be useful to include > (the removal of) those uses in this PR. > > ../libcxx/include/atomic:#define ATOMIC_VAR_INIT(value)

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

Quuxplusone added a comment. If libc++ is using these macros, then I think it would be useful to include (the removal of) those uses in this PR. ../libcxx/include/atomic:#define ATOMIC_VAR_INIT(value) see below ../libcxx/include/atomic:#define ATOMIC_FLAG_INIT see below ../libcxx/include/a

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a project: libc++. aaron.ballman added a subscriber: libcxx-commits. aaron.ballman added a comment. Subscribing the libc++ commits list in an attempt to get the attention of a libc++ reviewer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. ping @ldionne or @cjdb for libc++ review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D112221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

erichkeane accepted this revision. erichkeane added a comment. This revision is now accepted and ready to land. These look fine, I was hoping that someone else from library would take a look, but it looks right ot me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://re

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman added a comment. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D112221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman updated this revision to Diff 382092. aaron.ballman added a comment. Rebased and hopefully fixes the CI pipeline failures. I find it very odd that Linux was failing but Windows was not... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112221/new/ https://reviews.llvm.org/D

[PATCH] D112221: Mark ATOMIC_VAR_INIT and ATOMIC_FLAG_INIT as deprecated

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, ldionne, cjdb, erichkeane. aaron.ballman requested review of this revision. Herald added a project: clang. C17 deprecated `ATOMIC_VAR_INIT` with the resolution of DR 485. C++ followed suit when adopting P0883R2 for C++20,