[PATCH] D112089: consteval if does not form a discarded statement

aaron.ballman closed this revision. aaron.ballman added a comment. I've commit in ab2ca8496d54573de1c8bec204009567ba2b4086 and filed https://bugs.llvm.org/show_bug.cgi?id=52231 as the bug for the remaining bits, thanks for th

[PATCH] D112089: consteval if does not form a discarded statement

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1445-1450 Sema::ExpressionEvaluationContext Context = Sema::ExpressionEvaluationContext::DiscardedStatement; -if (NotLocation.isInvalid() && IsConsteval) +if (NotLocation.isInvalid() &

[PATCH] D112089: consteval if does not form a discarded statement

rsmith accepted this revision. rsmith added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1445-1450 Sema::ExpressionEvaluationContext Context = Sema::ExpressionEvaluationContext::DiscardedStatement; -if (NotLocation.isInvalid() && IsConsteval) +

[PATCH] D112089: consteval if does not form a discarded statement

rsmith added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1445-1450 Sema::ExpressionEvaluationContext Context = Sema::ExpressionEvaluationContext::DiscardedStatement; -if (NotLocation.isInvalid() && IsConsteval) +if (NotLocation.isInvalid() &&

[PATCH] D112089: consteval if does not form a discarded statement

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Oups, Sorry I missed that in my earlier PR. This fix LGTM. Thanks Aaron Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112089/new/ https://re

[PATCH] D112089: consteval if does not form a discarded statement

aaron.ballman created this revision. aaron.ballman added reviewers: cor3ntin, erichkeane, rsmith. aaron.ballman requested review of this revision. Herald added a project: clang. When we added support for `if consteval`, we accidentally formed a discarded statement evaluation context for the branc