This revision was automatically updated to reflect the committed changes.
Closed by commit rG6d314ee57097: [clangd] Add a way to enable IncludeCleaner
through config (authored by kbobyrev).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111870/new/
h
kbobyrev updated this revision to Diff 382242.
kbobyrev marked 4 inline comments as done.
kbobyrev added a comment.
Resolve the review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111870/new/
https://reviews.llvm.org/D111870
Files:
cl
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Awesome, let's ship it!
Only nits on the text, feel free to ignore any you don't like
Comment at: clang-tools-extra/clangd/ConfigFragment.h:213
+/// Controls how
kbobyrev updated this revision to Diff 382215.
kbobyrev added a comment.
Use IncludeCleaner to get rid of unused include in IncludeCleaner.cpp 🆒
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111870/new/
https://reviews.llvm.org/D111870
Files:
cl
kbobyrev updated this revision to Diff 382214.
kbobyrev marked an inline comment as done.
kbobyrev added a comment.
Resolve review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111870/new/
https://reviews.llvm.org/D111870
Files:
clang-
kbobyrev marked 9 inline comments as done.
kbobyrev added inline comments.
Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:215
+D.Message = "Included header is unused";
+D.Name = "clangd-include-cleaner";
+// FIXME: This range should be the whole line with tar
sammccall added a comment.
Mostly dumb nitpicks because this is user-facing magic strings... let's chat
before doing another round so I'm not wasting your time.
---
You've done some renaming from UnusedInclude -> UnusedHeaders.
I feel bad because I did say in the last round
> "Unused headers"
kbobyrev updated this revision to Diff 381192.
kbobyrev added a comment.
Prevent accidental changes from getting into this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111870/new/
https://reviews.llvm.org/D111870
Files:
clang-tools-extra
kbobyrev updated this revision to Diff 381190.
kbobyrev added a comment.
[clangd] IncludeCleaner: Implement more complicated rules for considering enums
forward declarations "used"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111870/new/
https://
kbobyrev updated this revision to Diff 381157.
kbobyrev added a comment.
Elaborate a bit more on Strict mode for UnusedHeaders.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111870/new/
https://reviews.llvm.org/D111870
Files:
clang-tools-extra/c
kbobyrev updated this revision to Diff 380702.
kbobyrev added a comment.
Rebase on top of main, revert unwanted formatting change.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111870/new/
https://reviews.llvm.org/D111870
Files:
clang-tools-extr
kbobyrev updated this revision to Diff 380665.
kbobyrev marked 16 inline comments as done.
kbobyrev added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111870/new/
https://reviews.llvm.org/D111870
Files:
clang
sammccall added inline comments.
Comment at: clang-tools-extra/clangd/Config.h:89
/// Controls warnings and errors when parsing code.
+ enum IncludeCleanerPolicy { UnusedHeaders, None };
you've accidentally split this comment from its decl
===
kbobyrev updated this revision to Diff 380426.
kbobyrev added a comment.
Fix the warning range.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111870/new/
https://reviews.llvm.org/D111870
Files:
clang-tools-extra/clangd/Config.h
clang-tools-ext
kbobyrev updated this revision to Diff 379944.
kbobyrev added a comment.
Delete debugging leftovers.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111870/new/
https://reviews.llvm.org/D111870
Files:
clang-tools-extra/clangd/Config.h
clang-tool
kbobyrev created this revision.
kbobyrev added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman.
kbobyrev requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added a project: clang-tools-extra.
This is useful for do
16 matches
Mail list logo
