This revision was automatically updated to reflect the committed changes.
Closed by commit rL262582: [OPENMP 4.0] Initial support for 'omp declare
reduction' construct. (authored by ABataev).
Changed prior to commit:
http://reviews.llvm.org/D11182?vs=45149&id=49707#toc
Repository:
rL LLVM
h
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
Sorry for the delay, LGTM
Comment at: lib/Sema/SemaExpr.cpp:377
@@ +376,3 @@
+ auto *DRD = dyn_cast(CurContext);
+ if ((LangOpts.OpenMP != 0u) && (DRD != nullptr) &&
+
ABataev added a comment.
Ping
http://reviews.llvm.org/D11182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
Richard?
http://reviews.llvm.org/D11182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev updated this revision to Diff 45149.
ABataev added a comment.
Simplified handling of private copies in C/C++. Now all outpup parameters of
UDR must be passed by pointer, not by reference (better compatibility with C)
http://reviews.llvm.org/D11182
Files:
include/clang/AST/DeclBase.h
ABataev updated this revision to Diff 44848.
ABataev added a comment.
Updated to latest version + some fixes and improvements
http://reviews.llvm.org/D11182
Files:
include/clang/AST/DeclBase.h
include/clang/AST/DeclCXX.h
include/clang/AST/DeclOpenMP.h
include/clang/AST/RecursiveASTVisit
ABataev added a comment.
Richard, could you take a look one more time, please?
http://reviews.llvm.org/D11182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
Richard, could you take a look one more time, please?
http://reviews.llvm.org/D11182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev updated this revision to Diff 40262.
ABataev marked 2 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D11182
Files:
include/clang/AST/DataRecursiveASTVisitor.h
include/clang/AST/DeclBase.h
include/clang/AST/DeclCXX.h
include/clang/AS
ABataev marked 2 inline comments as done.
Comment at: include/clang/Basic/DiagnosticParseKinds.td:995
@@ -994,1 +994,3 @@
+def err_omp_expected_reduction_identifier : Error<
+ "expected identifier or one of the following operators: '+', '-', '*', '&',
'|', '^', '&&' and '||'">;
hfinkel added inline comments.
Comment at: include/clang/Basic/DiagnosticParseKinds.td:995
@@ -994,1 +994,3 @@
+def err_omp_expected_reduction_identifier : Error<
+ "expected identifier or one of the following operators: '+', '-', '*', '&',
'|', '^', '&&' and '||'">;
-
ABataev updated this revision to Diff 37321.
ABataev marked 16 inline comments as done.
ABataev added a comment.
Update after review
http://reviews.llvm.org/D11182
Files:
include/clang/AST/DataRecursiveASTVisitor.h
include/clang/AST/DeclBase.h
include/clang/AST/DeclCXX.h
include/clang/A
ABataev marked 40 inline comments as done.
ABataev added a comment.
Richard, thanks for the review! Tried to fix all your comments.
Comment at: include/clang/AST/DeclOpenMP.h:95
@@ +94,3 @@
+/// #pragma omp declare reduction (foo : int,float : omp_out += omp_in)
+/// initializer
rsmith added inline comments.
Comment at: include/clang/AST/DeclOpenMP.h:95
@@ +94,3 @@
+/// #pragma omp declare reduction (foo : int,float : omp_out += omp_in)
+/// initializer (omp_priv = 0)
+/// \endcode
I think automatic formatting has messed up your example.
ABataev added a comment.
Ping
http://reviews.llvm.org/D11182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
Richard?
http://reviews.llvm.org/D11182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ABataev added a comment.
Ping
http://reviews.llvm.org/D11182
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fraggamuffin added a comment.
Got it. Test results look good with this patch.
Expected Passes: 7011
Expected Failures : 21
Unsupported Tests : 89
Unexpected Failures: 47
http://reviews.llvm.org/D11182
___
cfe-commits mailing list
cfe-
ABataev updated this revision to Diff 32792.
ABataev added a comment.
Updated to latest version.
http://reviews.llvm.org/D11182
Files:
include/clang/AST/DataRecursiveASTVisitor.h
include/clang/AST/DeclBase.h
include/clang/AST/DeclOpenMP.h
include/clang/AST/RecursiveASTVisitor.h
includ
I'll update patch, Michael
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
20.08.2015 18:40, Michael Wong пишет:
fraggamuffin added a comment.
Comment at: lib/Parse/ParseDeclCXX.cpp:3011
@@ -3010,3 +3010,3 @@
if (Tok.is(tok::annot_pra
ABataev added a subscriber: ABataev.
ABataev added a comment.
I'll update patch, Michael
Best regards,
Alexey Bataev
=
Software Engineer
Intel Compiler Team
20.08.2015 18:40, Michael Wong пишет:
> fraggamuffin added a comment.
>
>
> Comment at: lib/Parse/Pars
fraggamuffin added a comment.
Comment at: lib/Parse/ParseDeclCXX.cpp:3011
@@ -3010,3 +3010,3 @@
if (Tok.is(tok::annot_pragma_openmp)) {
-ParseOpenMPDeclarativeDirective();
continue;
While testing this patch with the latest trunk for my w
22 matches
Mail list logo
