[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf92db6d3fff1: [HIP] Relax conditions for address space cast in builtin args (authored by gandhi21299). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 updated this revision to Diff 380098. gandhi21299 added a comment. cleaned up code for readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 Files: clang/lib/Sema/SemaExpr.cpp clang/

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

tra added a comment. In D111734#3067624 , @gandhi21299 wrote: > @tra I see, we sure can rewrite that segment for readability. It could've been done with a follow-up clean-up commit. revert/reland works, too. Thank you for following up on the comment,

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 added a comment. @tra I see, we sure can rewrite that segment for readability. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 ___ cfe-commits maili

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

This revision was automatically updated to reflect the committed changes. Closed by commit rG3b48e1170dc6: [HIP] Relax conditions for address space cast in builtin args (authored by gandhi21299). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/n

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

tra accepted this revision. tra added a comment. LGTM in general, modulo a readability suggestion. Comment at: clang/lib/Sema/SemaExpr.cpp:6548-6550 +// Prevent addrspace cast if the parameter has a default address +// space, or the argument has a non-default ad

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 added a comment. Thanks for the review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 __

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 updated this revision to Diff 380067. gandhi21299 marked 3 inline comments as done. gandhi21299 added a comment. corrected sema test, as requested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D11173

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

tra added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6548-6550 +// Prevent addrspace cast if the parameter has a default address +// space, or the argument has a non-default addrspace and the +// target addrspaces of the argument and the para

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 updated this revision to Diff 380048. gandhi21299 added a comment. removed unused diagnostic sema note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 Files: clang/lib/Sema/SemaExpr.cpp cl

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 updated this revision to Diff 380047. gandhi21299 added a comment. installed clang-format, refreshing patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 Files: clang/include/clang/Basic/D

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 updated this revision to Diff 380046. gandhi21299 added a comment. adding sema test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 added a comment. Passed internal CI, still working on a Sema test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 ___ cfe-commits mailing list cfe-

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

tra added a comment. I think for a Sema change there should be a **Sema** test, too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 ___ cfe-commits mailing lis

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 updated this revision to Diff 379444. gandhi21299 marked an inline comment as done. gandhi21299 added a comment. adding codegen test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 Files: cl

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

yaxunl added a comment. we need a codegen test for the case Comment at: clang/lib/Sema/SemaExpr.cpp:6550 // type to a default address space pointee type -if (ArgAS != LangAS::Default || ParamAS == LangAS::Default) continue; we still

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 updated this revision to Diff 379419. gandhi21299 added a comment. removed irrelevant lines in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111734/new/ https://reviews.llvm.org/D111734 Files: clang/lib/Sema/SemaExpr.cpp c

[PATCH] D111734: [HIP] Relax conditions for address space cast in builtin args

gandhi21299 created this revision. gandhi21299 added a reviewer: yaxunl. gandhi21299 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow (implicit) address space casting between LLVM-equivalent target address spaces. Repository: rG LL