This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGb6a8c695542b: [NFC] Rename EmitAssemblyHelper new/legacy PM
methods (authored by aeubanks).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAS
aeubanks updated this revision to Diff 379208.
aeubanks added a comment.
add comment
I'd rather switch everything to lowerCamel at once rather than just a few
methods
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111680/new/
https://reviews.llvm.o
MaskRay added inline comments.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:175
+ void EmitAssemblyWithLegacyPassManager(BackendAction Action,
+ std::unique_ptr
OS);
Perhaps add a comment to bring awareness to possible
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
Consider switching to `functionName` while updating the function names.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111680/new/
https://revi
aeubanks created this revision.
aeubanks added a reviewer: MaskRay.
Herald added a subscriber: ormris.
Herald added a reviewer: ctetreau.
Herald added a reviewer: ctetreau.
Herald added a reviewer: ctetreau.
aeubanks requested review of this revision.
Herald added a project: clang.
Herald added a s
