[PATCH] D111640: [Analyzer][NFC] Add RangedConstraintManager to ConstraintAssignor

2021-10-22 Thread Gabor Marton via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2a2c8328f57: [Analyzer][NFC] Add RangedConstraintManager to ConstraintAssignor (authored by martong). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D111640: [Analyzer][NFC] Add RangedConstraintManager to ConstraintAssignor

2021-10-12 Thread Denys Petrov via Phabricator via cfe-commits
ASDenysPetrov added a comment. In D111640#3058622 , @martong wrote: > In D111640#3058304 , @steakhal > wrote: > >> It looks good. >> Do you think we could remove the `RangedConstraintManager` abstraction? > > Def

[PATCH] D111640: [Analyzer][NFC] Add RangedConstraintManager to ConstraintAssignor

2021-10-12 Thread Gabor Marton via Phabricator via cfe-commits
martong added a comment. In D111640#3058304 , @steakhal wrote: > It looks good. > Do you think we could remove the `RangedConstraintManager` abstraction? Definitely. What's more, we could split out cohesive implementation details like `RangeSet`, `Equiv

[PATCH] D111640: [Analyzer][NFC] Add RangedConstraintManager to ConstraintAssignor

2021-10-12 Thread Balázs Benics via Phabricator via cfe-commits
steakhal accepted this revision. steakhal added a comment. This revision is now accepted and ready to land. It looks good. Do you think we could remove the `RangedConstraintManager` abstraction? It shouldn't be hard to get rid of it. Regardless, it's good to go, but let's wait for the child revis

[PATCH] D111640: [Analyzer][NFC] Add RangedConstraintManager to ConstraintAssignor

2021-10-12 Thread Gabor Marton via Phabricator via cfe-commits
martong created this revision. martong added reviewers: steakhal, ASDenysPetrov, NoQ. Herald added subscribers: manas, gamesh411, dkrupp, donat.nagy, Szelethus, mikhail.ramalho, a.sidorin, rnkovacs, szepet, baloghadamsoftware, xazax.hun, whisperity. Herald added a reviewer: Szelethus. martong req