[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

jansvoboda11 updated this revision to Diff 378945. jansvoboda11 added a comment. Implemented alternative approach: attach the caching listener to PCH reading as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111560/new/ https://reviews.llvm.o

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:41 for (const PrebuiltModuleDep &PMD : PrebuiltModuleDeps) { -Args.push_back("-fmodule-file=" + PMD.ModuleName + "=" + PMD.PCMFile); +Args.push_back("-fmodule-

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

dexonsmith added a comment. In D111560#3056175 , @jansvoboda11 wrote: > In D111560#3056021 , @dexonsmith > wrote: > >> In D111560#3055578 , @jansvoboda11 >> wrote: >> >

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

jansvoboda11 added a comment. In D111560#3056021 , @dexonsmith wrote: > In D111560#3055578 , @jansvoboda11 > wrote: > >> Note: Another approach to fixing this might be to cache the module load >> results while

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

dexonsmith added a comment. In D111560#3055578 , @jansvoboda11 wrote: > Note: Another approach to fixing this might be to cache the module load > results while loading the PCH too. Can you share why you chose this approach instead, and which do you thi

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

jansvoboda11 added a comment. Note: Another approach to fixing this might be to cache the module load results while loading the PCH too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111560/new/ https://reviews.llvm.org/D111560 __

[PATCH] D111560: [clang][modules] Cache loads of explicit modules imported by PCH

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, rsmith. jansvoboda11 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. During modular build, PCM files are typically specified via the `-fmodule-file=`