[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

saiislam added a comment. In D111545#3218961 , @MyDeveloperDay wrote: > Nit: That is more correct, but actually, you normally make the comment match > the param name (I think there might even be a clang-tidy check for that?) > > i.e. > > /*isBitCodeSD

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG32357266fd05: [Clang][NFC] Fix multiline comment prefixes in function headers (authored by saiislam). Changed prior to commit: https://reviews.llv

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

MyDeveloperDay added a comment. That is more correct, but actually, you normally make the comment match the param name (I think there might even be a clang-tidy check for that?) i.e. /*isBitCodeSDL=*/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

saiislam updated this revision to Diff 397073. saiislam added a comment. Updated comments as per suggestion. Apologies for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111545/new/ https://reviews.llvm.org/D111545 Files: clang/lib/Dri

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

MyDeveloperDay requested changes to this revision. MyDeveloperDay added a comment. This revision now requires changes to proceed. To me you should be doing /*bitcode SDL=*/true It looks like its still failing clang-format might I suggest making the changes to the comment, git adding the file

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

saiislam updated this revision to Diff 378957. saiislam added a comment. Used comment style for named parameters. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111545/new/ https://reviews.llvm.org/D111545 Files: clang/lib/Driver/ToolChains/AMDGP

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

MyDeveloperDay added a comment. what @thakis said, this isn't normally my area but this is one of the files that has reverted its "clang-format clean" status with recent commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111545/new/ https://re

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

thakis added inline comments. Comment at: clang/lib/Driver/ToolChains/AMDGPUOpenMP.cpp:118 AddStaticDeviceLibsLinking(C, *this, JA, Inputs, Args, CmdArgs, "amdgcn", - SubArchName, - /* bitcode SDL?*/ true, - /* Pos

[PATCH] D111545: [Clang][NFC] Fix multiline comment prefixes in function headers

saiislam created this revision. saiislam added a reviewer: MyDeveloperDay. Herald added subscribers: kerbowa, nhaehnle, jvesely. saiislam requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Cleanup of D105191