[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

2022-08-02 Thread Alok Kumar Sharma via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5ec6ea3dfded: [clang][OpenMP][DebugInfo] Mark OpenMP generated functions as artificial (authored by alok). Repository: rG LLVM Github Monorepo CH

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

2022-08-02 Thread Alok Kumar Sharma via Phabricator via cfe-commits
alok updated this revision to Diff 449239. alok added a comment. Re-based and updated to incorporate comments from @dblaikie CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111521/new/ https://reviews.llvm.org/D111521 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/OpenMP/outline

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

2022-06-15 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D111521#3584439 , @alok wrote: > Re-based and updated to include one negative testcase. > I could not find a test for VarDecl with DynamicInitKind::NoStub. There are > constructors for other DynamicInitKind but not for NoStub

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

2022-06-15 Thread Alok Kumar Sharma via Phabricator via cfe-commits
alok updated this revision to Diff 437064. alok added a comment. Herald added a project: All. Re-based and updated to include one negative testcase. I could not find a test for VarDecl with DynamicInitKind::NoStub. There are constructors for other DynamicInitKind but not for NoStub. Please help m

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

2021-10-11 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. Might not hurt to have some negative test cases too - like something that is a VarDecl but has NoStub DynamicInitKind? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111521/new/ https://reviews.llvm.org/D111521 __

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

2021-10-11 Thread Djordje Todorovic via Phabricator via cfe-commits
djtodoro added a comment. This looks reasonable to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111521/new/ https://reviews.llvm.org/D111521 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D111521: [DebugInfo] Mark OpenMP generated functions as artificial

2021-10-10 Thread Alok Kumar Sharma via Phabricator via cfe-commits
alok created this revision. alok added reviewers: aprantl, djtodoro, jmorse, dblaikie, jini.susan, jini.susan.george. alok added a project: debug-info. Herald added subscribers: guansong, yaxunl. alok requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: