This revision was automatically updated to reflect the committed changes.
Closed by commit rG55a79318c60d: [clang][clangd] Improve signature help for
variadic functions. (authored by adamcz).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111318/new/
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:929
+//
+// This only matters for variadic functions/templates, where CurrentArg
+// m
adamcz added a comment.
Added a slightly awkward clang (not clangd) test. The output is suboptimial,
because it's not clangd, but it shows things work as they should.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:929
+//
+// This only matters for variad
adamcz updated this revision to Diff 388167.
adamcz marked an inline comment as done.
adamcz added a comment.
addressed review comments, added new test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111318/new/
https://reviews.llvm.org/D111318
File
sammccall added a comment.
Thanks, this looks nice!
Since the code is in Sema, we'd should (also) test this in
`clang/test/CodeCompletion/` if possible.
Comment at: clang-tools-extra/clangd/CodeComplete.cpp:928
+// FIXME: Add support for per-signature activeParameter
adamcz added a comment.
Sorry for delay, I got distracted with other stuff. I addressed your comment,
partially, and also added more tests and fixed one more issue (see the
FunctionType test, it would've failed before).
Comment at: clang/lib/Sema/SemaOverload.cpp:6460
// l
adamcz updated this revision to Diff 385071.
adamcz added a comment.
addressed review comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111318/new/
https://reviews.llvm.org/D111318
Files:
clang-tools-extra/clangd/CodeComplete.cpp
clang-too
sammccall added a comment.
Thanks, this looks great, just want to check if there are more callsites we can
hit while here.
Comment at: clang/lib/Sema/SemaOverload.cpp:6460
// list (8.3.5).
if (TooManyArguments(NumParams, Args.size(), PartialOverloading) &&
!Proto-
adamcz created this revision.
adamcz added a reviewer: sammccall.
Herald added subscribers: usaxena95, kadircet, arphaman.
adamcz requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Herald added projects: clang, clang-tools-extra.
This covers both C-st
