[PATCH] D111264: Comment AST: Declare function pointer variables as functions

2021-11-09 Thread Aaron Puchert via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4d6382430066: Comment AST: Declare function pointer variables as functions (authored by aaronpuchert). Changed prior to commit: https://reviews.ll

[PATCH] D111264: Comment AST: Declare function pointer variables as functions

2021-11-09 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert added a comment. In D111264#3115104 , @gribozavr2 wrote: > I feel uneasy about claiming that variable decls of function type are > FunctionKind for the purposes of comment parsing (even doing it for typedefs > is questionable). It seems li

[PATCH] D111264: Comment AST: Declare function pointer variables as functions

2021-11-08 Thread Dmitri Gribenko via Phabricator via cfe-commits
gribozavr2 accepted this revision. gribozavr2 added a comment. This revision is now accepted and ready to land. I feel uneasy about claiming that variable decls of function type are FunctionKind for the purposes of comment parsing (even doing it for typedefs is questionable). It seems like a bet

[PATCH] D111264: Comment AST: Declare function pointer variables as functions

2021-10-06 Thread Aaron Puchert via Phabricator via cfe-commits
aaronpuchert created this revision. aaronpuchert added reviewers: gribozavr2, Mordante. aaronpuchert requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We were doing this already for type aliases, and it deduplicates the code looking through a