kadircet closed this revision.
kadircet marked an inline comment as done.
kadircet added a comment.
Landed as
https://github.com/llvm/llvm-project/commit/4e4511df8d33a6fc02d5e46c681855db495187cd
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111224/
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/unittests/AST/RecursiveASTVisitorTest.cpp:130
+TEST(RecursiveASTVisitorTest, EnumDeclWithBase) {
+ /// Check attributes are traversed inside Trav
kadircet updated this revision to Diff 377652.
kadircet marked 3 inline comments as done.
kadircet added a comment.
- split changes in libindex
- fix the issue with non-traversal of forward-decls
- add unittests into RAV
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://
hokein added a comment.
the RAV change looks good.
I think it might be worth to split this patch (one for RAV, one for libindex).
Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:1866
+ if (auto *TSI = D->getIntegerTypeSourceInfo())
+TRY_TO(TraverseTypeLoc(TSI-
kadircet updated this revision to Diff 377527.
kadircet added a comment.
- Fix tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111224/new/
https://reviews.llvm.org/D111224
Files:
clang-tools-extra/clangd/unittests/SemanticHighlightingTests.c
kadircet created this revision.
kadircet added reviewers: nridge, hokein.
Herald added subscribers: usaxena95, arphaman.
kadircet requested review of this revision.
Herald added projects: clang, clang-tools-extra.
Herald added a subscriber: cfe-commits.
Visit enum integer-base specifiers explicitl
