[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

2021-10-10 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. @Quuxplusone fixed, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111215/new/ https://reviews.llvm.org/D111215 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

2021-10-10 Thread Arthur O'Dwyer via Phabricator via cfe-commits
Quuxplusone added inline comments. Comment at: clang/docs/ReleaseNotes.rst:54 -- ... +- -Wbitwise-instead-of-logical (part of -Wbool-operation) warns about use of bitwise with boolean operands xbolva00 wrote: > I think we should mention that with boolean ope

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

2021-10-10 Thread Sylvestre Ledru via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9c8f950a0400: clang release notes: document the -Wbool-operation improvement (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

2021-10-06 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru updated this revision to Diff 377486. sylvestre.ledru added a comment. add "which have side effects" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111215/new/ https://reviews.llvm.org/D111215 Files: clang/docs/ReleaseNotes.rst

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

2021-10-06 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added a comment. First form is better I think. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111215/new/ https://reviews.llvm.org/D111215 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

2021-10-06 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru added a comment. @xbolva00 sorry but you would like -Wbitwise-instead-of-logical (part of -Wbool-operation) warns about use of bitwise with boolean operands which have side effects or -Wbitwise-instead-of-logical (part of -Wbool-operation) warns about use of bitwise with boole

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

2021-10-06 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 accepted this revision. xbolva00 added a comment. This revision is now accepted and ready to land. One small comment about side effects, otherwise LG. Please wait a +-day for potentional review comments. Comment at: clang/docs/ReleaseNotes.rst:54 -- ... +- -Wbitwise

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

2021-10-06 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru updated this revision to Diff 377483. sylvestre.ledru added a comment. Take in account the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111215/new/ https://reviews.llvm.org/D111215 Files: clang/docs/ReleaseNotes.rst In

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

2021-10-06 Thread Dávid Bolvanský via Phabricator via cfe-commits
xbolva00 added inline comments. Comment at: clang/docs/ReleaseNotes.rst:54 -- ... +- -Wbool-operation warns about use of bitwise with boolean operands -Wbitwise-instead-of-logical (part of -Wbool-operation) warns … ? Repository: rG LLVM Github Monorepo

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

2021-10-06 Thread Sylvestre Ledru via Phabricator via cfe-commits
sylvestre.ledru created this revision. sylvestre.ledru added reviewers: xbolva00, nathanchance. sylvestre.ledru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111215 Files: