This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG3b93dc6880f7: Add basic aarch64-none-elf bare metal driver.
(authored by kristof.beyls).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
kristof.beyls added a comment.
@MaskRay - gentle ping: I wonder if you have any further remarks after I
updated the patch based on your earlier feedback?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D34/new/
https://reviews.llvm.org/D34
kristof.beyls updated this revision to Diff 377818.
kristof.beyls added a comment.
run clang-format on the patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D34/new/
https://reviews.llvm.org/D34
Files:
clang/lib/Driver/ToolChains/BareMetal.cpp
clang/test/Driver/baremetal.
kristof.beyls added inline comments.
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:133
+
+ if (Triple.getVendor() != llvm::Triple::UnknownVendor)
+return false;
MaskRay wrote:
> Is vendor check necessary?
I'm guessing that without the vendor check, t
kristof.beyls updated this revision to Diff 377816.
kristof.beyls added a comment.
Updated test based on feedback from @MaskRay
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D34/new/
https://reviews.llvm.org/D34
Files:
clang/lib/Driver/ToolChains/BareMetal.cpp
clang/test/Dri
MaskRay added inline comments.
Comment at: clang/lib/Driver/ToolChains/BareMetal.cpp:133
+
+ if (Triple.getVendor() != llvm::Triple::UnknownVendor)
+return false;
Is vendor check necessary?
Comment at: clang/test/Driver/baremetal.cpp:105
peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.
LGTM thanks for the update. This looks like it follows the same format as the
other -none-elf toolchains, and AArch64 can benefit from the bare-metal
driver for easier access to LLD.
kristof.beyls created this revision.
kristof.beyls added reviewers: psmith, miyuki, srhines.
Herald added subscribers: s.egerton, simoncook.
kristof.beyls requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
