more.edu ;
> jlero...@apple.com ; chris.biene...@me.com <
> chris.biene...@me.com>; aaron.ball...@gmail.com
> *Cc:* ale...@google.com ; ndesaulni...@google.com <
> ndesaulni...@google.com>; cfe-commits@lists.llvm.org <
> cfe-commits@lists.llvm.org>; david.gr...@a
On Wed, Oct 20, 2021 at 5:28 PM stan li wrote:
>
> Hi Alex,
>
> I’ll take a look. Not sure how long it takes though.
>
> Please revert it. I don’t have the permission to commit yet.
I've reverted in aad244dfc566236e9d3ef48c7aea3616bb6aab14 while the
crash is being investigated.
~Aaron
__
.biene...@me.com ; aaron.ball...@gmail.com
Cc: ale...@google.com ; ndesaulni...@google.com
; cfe-commits@lists.llvm.org
; david.gr...@arm.com ;
ruiling.s...@amd.com
Subject: [PATCH] D111109: AddGlobalAnnotations for function with or without
function body.
alexfh added a comment.
Reduced th
.@google.com<mailto:ndesaulni...@google.com>;
cfe-commits@lists.llvm.org<mailto:cfe-commits@lists.llvm.org>;
david.gr...@arm.com<mailto:david.gr...@arm.com>;
ruiling.s...@amd.com<mailto:ruiling.s...@amd.com>
Subject: [PATCH] D09: AddGlobalAnnotations for function with or wi
alexfh added a comment.
Reduced the test further to:
struct k {
~k() __attribute__((annotate(""))) {}
};
void m() { k(); }
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D09/new/
https://reviews.llvm.org/D09
__
alexfh added a comment.
Reduced test case:
template void b(a);
template class d {
public:
class e {
public:
c *f();
};
e *g();
};
template class j;
template class j {
public:
class k {
public:
k(int *);
~k();
};
int n();
d l;
alexfh added a comment.
It looks like this patch causes clang to crash on valid code with the following
stack trace:
#0 0x560442f12f45 SignalHandler(int)
#1 0x7ffac7c789a0 __restore_rt
#2 0x560440083992 llvm::LazyCallGraph::Node::populateSlow()
#3 0x560440082a60 llvm:
python3kgae added a comment.
Thanks for the review, the PR is committed.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D09/new/
https://reviews.llvm.org/D09
___
cfe-commits mailing list
cfe-commit
This revision was automatically updated to reflect the committed changes.
Closed by commit rG121b2252de0e: AddGlobalAnnotations for function with or
without function body. (authored by beanz).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D09/new/
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D09/new/
https://reviews.llvm.org/D09
python3kgae added a comment.
Updated summary.
Tried to debug the linux fail with Hyper-V VM, cannot repro.
Restarted Buildkite build to see if it still happens.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D09/new/
https://reviews.llvm.org/D11
aaron.ballman added a comment.
I think this is reasonable, but can you update the summary to also explain why
these changes are useful?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D09/new/
https://reviews.llvm.org/D09
___
python3kgae updated this revision to Diff 377323.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D09/new/
https://reviews.llvm.org/D09
Files:
clang/lib/CodeGen/CodeGenModule.cpp
clang/test/CodeGen/annotations-global.c
clang/test/CodeGenC
python3kgae created this revision.
python3kgae added a reviewer: clang.
python3kgae added a project: clang.
python3kgae requested review of this revision.
Herald added a subscriber: cfe-commits.
When AnnotateAttr is on a function, AddGlobalAnnotations is only called in
CodeGenModule::EmitGlobalFu
14 matches
Mail list logo
