[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

2021-10-06 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. In D05#3046631 , @aeubanks wrote: > In D05#3046585 , @dblaikie > wrote: > >>> This is similar to perf testing which we don't really have in tree tests >>> for. Typically these t

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

2021-10-06 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added a comment. In D05#3046585 , @dblaikie wrote: >> This is similar to perf testing which we don't really have in tree tests >> for. Typically these things are mostly monitored separately (e.g. >> llvm-compile-time-tracker). > > Except in

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

2021-10-06 Thread David Blaikie via Phabricator via cfe-commits
dblaikie added a comment. > This is similar to perf testing which we don't really have in tree tests for. > Typically these things are mostly monitored separately (e.g. > llvm-compile-time-tracker). Except in this case it isn't tested at all because it's behind a flag. Unless we're bringing up

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

2021-10-06 Thread Arthur Eubanks via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6522b7cc3240: [clang] Add option to clear AST memory before running LLVM passes (authored by aeubanks). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

2021-10-06 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 377669. aeubanks added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D05/new/ https://reviews.llvm.org/D05 Files: clang/include/clang/Basic/CodeGenOptions.def clang/include/clang/

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

2021-10-06 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks added inline comments. Comment at: clang/test/Misc/clear-ast-before-backend.c:2-3 +// RUN: %clang -target x86_64-linux-gnu -c -Xclang -clear-ast-before-backend %s -S +// RUN: %clang -target x86_64-linux-gnu -c -Xclang -clear-ast-before-backend %s -S -### 2>&1 | FileChe

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

2021-10-05 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. In D05#3043734 , @aeubanks wrote: > update test > I checked to make sure that we're not accepting -clear-ast-before-backend as > a driver flag

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

2021-10-05 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks updated this revision to Diff 377333. aeubanks added a comment. update test I checked to make sure that we're not accepting -clear-ast-before-backend as a driver flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D05/new/ https://revie

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

2021-10-05 Thread David Blaikie via Phabricator via cfe-commits
dblaikie requested changes to this revision. dblaikie added a subscriber: aaron.ballman. dblaikie added a comment. This revision now requires changes to proceed. Oh, looking at this ab it further I do have some things to discuss. Comment at: clang/include/clang/Driver/Options.t

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

2021-10-05 Thread David Blaikie via Phabricator via cfe-commits
dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Seems like a good place to start with experimentation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D05/new/ https://reviews.llvm.org/D1

[PATCH] D111105: [clang] Add option to clear AST memory before running LLVM passes

2021-10-04 Thread Arthur Eubanks via Phabricator via cfe-commits
aeubanks created this revision. Herald added subscribers: dexonsmith, dang. aeubanks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is to save memory for Clang compiles. Measuring building PassBuilder.cpp under /usr/bin/time, max rss