[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8e218026f8d5: [clang] [MinGW] Fix paths on Gentoo (authored by maharmstone, committed by mstorsjo). Herald added a project: clang. Repository: rG

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

maharmstone added a comment. In D111081#3633908 , @mstorsjo wrote: > LGTM, thanks, and sorry for losing track of it earlier. > > Do you need someone to push the patch for you? In that case, can you provide > your preferred git author line for the patch?

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mstorsjo accepted this revision. mstorsjo added a comment. This revision is now accepted and ready to land. LGTM, thanks, and sorry for losing track of it earlier. Do you need someone to push the patch for you? In that case, can you provide your preferred git author line for the patch? CHANGES

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

maharmstone added a comment. In D111081#3627852 , @MaskRay wrote: > Does Gentoo patch upstream to do something different? (`.../g++-v10/...`) > Well, I wish that Gentoo does not do this. > This adds complexity to Clang which in practice tries to provide

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

MaskRay added a comment. Does Gentoo patch upstream to do something different? (`.../g++-v10/...`) Well, I wish that Gentoo does not do this. This adds complexity to Clang which in practice tries to provide some drop-in replacement ability. CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

maharmstone updated this revision to Diff 441952. maharmstone added a comment. Rebased patch against current upstream CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081 Files: clang/lib/Driver/ToolChains/MinGW.cpp clang/lib/Driver/ToolChains/

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mstorsjo added a comment. In D111081#3212890 , @mgorny wrote: > Well, I dunno how MinGW works, so can't judge that part. Furthermore, I'm > thoroughly confused why this works on top of existing (non-Gentoo?) test > tree. Could you explain it a bit more?

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mgorny added a comment. Well, I dunno how MinGW works, so can't judge that part. Furthermore, I'm thoroughly confused why this works on top of existing (non-Gentoo?) test tree. Could you explain it a bit more? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.l

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mstorsjo added a comment. Looks ok to me - WDYT @mgorny? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

maharmstone added a comment. I can't see that any of the lib paths are tested at all, though I may be missing something. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081 ___ cfe-commits mailing list

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

maharmstone updated this revision to Diff 378803. maharmstone added a comment. Added tests CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081 Files: clang/lib/Driver/ToolChains/MinGW.cpp clang/lib/Driver/ToolChains/MinGW.h clang/test/Driver

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mgorny added a comment. In D111081#3043831 , @mstorsjo wrote: > The change looks ok to me, but I think it'd be good to have a testcase for > finding these paths (IIRC there are a bunch of simulated sysroots under > clang/test/Driver). Seconded. There a

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mstorsjo added a comment. The change looks ok to me, but I think it'd be good to have a testcase for finding these paths (IIRC there are a bunch of simulated sysroots under clang/test/Driver). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081

[PATCH] D111081: [clang] [MinGW] Fix paths on Gentoo

mstorsjo added a reviewer: mstorsjo. mstorsjo added a subscriber: cfe-commits. mstorsjo added a comment. (I’ll have a look and comment on the patch later.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111081/new/ https://reviews.llvm.org/D111081 ___