[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42eea2b69bb9: [AIX] Enable int128 in 64 bit mode (authored by jsji). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji added a comment. In D111078#3065552 , @hubert.reinterpretcast wrote: > In D111078#3063245 , @lkail wrote: > >> This LGTM as the start point to support int128 on AIX. We might need more >> patches involving

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

hubert.reinterpretcast added a comment. In D111078#3063245 , @lkail wrote: > This LGTM as the start point to support int128 on AIX. We might need more > patches involving libraries in the LLVM monorepo, we can do that > progressively. Agreed (although

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

lkail accepted this revision as: lkail. lkail added a comment. This revision is now accepted and ready to land. This LGTM as the start point to support int128 on AIX. We might need more patches involving libraries in the LLVM monorepo, we can do that progressively. Repository: rG LLVM Github

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji added a comment. ppc64-i128-abi.ll CHECK-P9 part depends on D94282 : [PowerPC] Support ppc-asm-full-reg-names for AIX. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111078/new/ https://reviews.llvm.org/D11107

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji updated this revision to Diff 379485. jsji added a comment. Add AIX XCOFF triples to i128 tests, especially ppc64-i128-abi.ll. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111078/new/ https://reviews.llvm.org/D111078 Files: clang/lib/Basic

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

lkail added a comment. I would like to see more aix triple added to existing tests involving ABI in `llvm/test/CodeGen/PowerPC`(such as ppc64-i128-abi.ll), since AIX has independent calling convention lowering and is different from linux. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji added a comment. Ping @hubert.reinterpretcast Any further comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111078/new/ https://reviews.llvm.org/D111078 ___ cfe-commits mailing list cfe-commit

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji updated this revision to Diff 377283. jsji added a comment. Herald added a subscriber: kbarton. Address comments -- adding AIX triples to more existing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111078/new/ https://reviews.llvm.org/D

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

hubert.reinterpretcast added a comment. In D111078#3042913 , @daltenty wrote: > Good point, but the std::chrono::file_clock interface hasn't shipped yet on > the platform libc++, since it's currently still at a bit of a backlevel, so I > don't think tha

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

daltenty added a comment. > Making a change to whether a platform has __int128 affects the ABI of > libc++'s std::chrono::file_clock. We should make sure the mitigation patch is > posted and accepted. Good point, but the std::chrono::file_clock interface hasn't shipped yet on the platform libc

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji added inline comments. Comment at: llvm/test/CodeGen/PowerPC/int128_ldst.ll:31 ; CHECK-NEXT:mr 3, 5 ; CHECK-NEXT:blr entry: hubert.reinterpretcast wrote: > Confirming that this case matches GCC on AIX: > ``` > ld 4,8(3) > ld 3,0(3)

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

hubert.reinterpretcast added a comment. Type alignment (16), choice of GPRs for argument passing (first available including r10), `va_arg` invocations, order of components (big endian), and calls to double/float conversions all check out. It may be reasonable to locate existing tests for these

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

hubert.reinterpretcast added inline comments. Comment at: llvm/test/CodeGen/PowerPC/int128_ldst.ll:31 ; CHECK-NEXT:mr 3, 5 ; CHECK-NEXT:blr entry: Confirming that this case matches GCC on AIX: ``` ld 4,8(3) ld 3,0(3) blr ``` R

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

hubert.reinterpretcast added a comment. Making a change to whether a platform has `__int128` affects the ABI of libc++'s `std::chrono::file_clock`. We should make sure the mitigation patch is posted and accepted. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D111078: [AIX] Enable int128 in 64 bit mode

jsji created this revision. jsji added reviewers: PowerPC, hubert.reinterpretcast, nemanjai. jsji requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch remove the override in AIX target, so the int128 is enabled in 64