This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc99b2c63169d: CUDA/HIP: Allow __int128 on the host side
(authored by linjamaki, committed by tra).
Repository:
rG LLVM Github Monorepo
CHANGES SI
linjamaki added a comment.
This patch should be ready to land. @tra, could you please commit it to the
LLVM for us? Thanks.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111047/new/
https://reviews.llvm.org/D111047
___
linjamaki updated this revision to Diff 395649.
linjamaki added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111047/new/
https://reviews.llvm.org/D111047
Files:
clang/lib/Sema/Sema.cpp
clang/lib/Sema/SemaType.cpp
clang/te
linjamaki updated this revision to Diff 387511.
linjamaki added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111047/new/
https://reviews.llvm.org/D111047
Files:
clang/lib/Sema/Sema.cpp
clang/lib/Sema/SemaType.cpp
clang/te
linjamaki added a comment.
Thanks for the review. Updated the patch with the style suggestions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111047/new/
https://reviews.llvm.org/D111047
___
cfe-commits
linjamaki updated this revision to Diff 382228.
linjamaki added a comment.
Rephrase expressions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111047/new/
https://reviews.llvm.org/D111047
Files:
clang/lib/Sema/Sema.cpp
clang/lib/Sema/SemaType.
tra added a comment.
LGTM. This could be useful for other types.
E.g. `long double` is technically not supported by NVPTX. We current demote it
to double, so host-side does not cause errors, but ideally it should be treated
similar to what you propose for i128 here.
Comment
linjamaki updated this revision to Diff 381858.
linjamaki added a comment.
Rebase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111047/new/
https://reviews.llvm.org/D111047
Files:
clang/lib/Sema/Sema.cpp
clang/lib/Sema/SemaType.cpp
clang/te
linjamaki created this revision.
Herald added a subscriber: yaxunl.
linjamaki edited the summary of this revision.
linjamaki added a reviewer: rsmith.
linjamaki added subscribers: bader, Anastasia.
linjamaki published this revision for review.
Herald added a reviewer: jdoerfert.
Herald added subscr